Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2721233003: DevTools: create help sub-menu (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 * @override 472 * @override
473 * @param {!UI.Context} context 473 * @param {!UI.Context} context
474 * @param {string} actionId 474 * @param {string} actionId
475 * @return {boolean} 475 * @return {boolean}
476 */ 476 */
477 handleAction(context, actionId) { 477 handleAction(context, actionId) {
478 switch (actionId) { 478 switch (actionId) {
479 case 'settings.show': 479 case 'settings.show':
480 Settings.SettingsScreen._showSettingsScreen(); 480 Settings.SettingsScreen._showSettingsScreen();
481 return true; 481 return true;
482 case 'settings.help': 482 case 'settings.documentation':
483 InspectorFrontendHost.openInNewTab('https://developers.google.com/web/to ols/chrome-devtools/'); 483 InspectorFrontendHost.openInNewTab('https://developers.google.com/web/to ols/chrome-devtools/');
484 return true; 484 return true;
485 case 'settings.shortcuts': 485 case 'settings.shortcuts':
486 Settings.SettingsScreen._showSettingsScreen(Common.UIString('Shortcuts') ); 486 Settings.SettingsScreen._showSettingsScreen(Common.UIString('Shortcuts') );
487 return true; 487 return true;
488 } 488 }
489 return false; 489 return false;
490 } 490 }
491 }; 491 };
492 492
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 return; 545 return;
546 var settings = extension.descriptor()['settings']; 546 var settings = extension.descriptor()['settings'];
547 if (settings && settings.indexOf(setting.name) !== -1) { 547 if (settings && settings.indexOf(setting.name) !== -1) {
548 InspectorFrontendHost.bringToFront(); 548 InspectorFrontendHost.bringToFront();
549 Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id'] ); 549 Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id'] );
550 success = true; 550 success = true;
551 } 551 }
552 } 552 }
553 } 553 }
554 }; 554 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698