Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/script-tests/service/garbage-collection-ran-during-success.js

Issue 2721233002: bluetooth: Better disconnected error messages for characteristic retrieval. (Closed)
Patch Set: Address dcheng's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 'use strict'; 1 'use strict';
2 promise_test(() => { 2 promise_test(() => {
3 let promise; 3 let promise;
4 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') 4 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
5 .then(() => requestDeviceWithKeyDown({ 5 .then(() => requestDeviceWithKeyDown({
6 filters: [{services: ['health_thermometer']}]})) 6 filters: [{services: ['health_thermometer']}]}))
7 .then(device => device.gatt.connect()) 7 .then(device => device.gatt.connect())
8 .then(gattServer => gattServer.getPrimaryService('health_thermometer')) 8 .then(gattServer => gattServer.getPrimaryService('health_thermometer'))
9 .then(service => { 9 .then(service => {
10 promise = assert_promise_rejects_with_message( 10 promise = assert_promise_rejects_with_message(
11 service.CALLS([ 11 service.CALLS([
12 getCharacteristic('measurement_interval')| 12 getCharacteristic('measurement_interval')|
13 getCharacteristics()| 13 getCharacteristics()|
14 getCharacteristics('measurement_interval')[UUID]]), 14 getCharacteristics('measurement_interval')[UUID]]),
15 new DOMException( 15 new DOMException(
16 'GATT Server disconnected while retrieving characteristics.', 16 'GATT Server is disconnected. Cannot retrieve characteristics. ' +
17 '(Re)connect first with `device.gatt.connect`.',
17 'NetworkError')); 18 'NetworkError'));
18 // Disconnect called to clear attributeInstanceMap and allow the 19 // Disconnect called to clear attributeInstanceMap and allow the
19 // object to get garbage collected. 20 // object to get garbage collected.
20 service.device.gatt.disconnect(); 21 service.device.gatt.disconnect();
21 }) 22 })
22 .then(runGarbageCollection) 23 .then(runGarbageCollection)
23 .then(() => promise); 24 .then(() => promise);
24 }, 'Garbage Collection ran during a FUNCTION_NAME call that succeeds. ' + 25 }, 'Garbage Collection ran during a FUNCTION_NAME call that succeeds. ' +
25 'Should not crash.'); 26 'Should not crash.');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698