Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: content/browser/browser_thread_unittest.cc

Issue 2721223004: Fix for BrowserThreadTest tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_thread_unittest.cc
diff --git a/content/browser/browser_thread_unittest.cc b/content/browser/browser_thread_unittest.cc
index 71cd598236d48faa34b99602ace654d57e3b0eb8..7ed1500adf4d41a123c02ee3878fbf9638210ea4 100644
--- a/content/browser/browser_thread_unittest.cc
+++ b/content/browser/browser_thread_unittest.cc
@@ -29,6 +29,13 @@ class BrowserThreadTest : public testing::Test {
void StopUIThread() { ui_thread_->Stop(); }
+ ~BrowserThreadTest() override {
+ ui_thread_ = nullptr;
jam 2017/03/02 01:07:04 nit: put it in Teardown to match Setup, i.e. move
+ file_thread_ = nullptr;
+ BrowserThreadImpl::ResetGlobalsForTesting(BrowserThread::UI);
+ BrowserThreadImpl::ResetGlobalsForTesting(BrowserThread::FILE);
+ }
+
protected:
void SetUp() override {
ui_thread_.reset(new BrowserThreadImpl(BrowserThread::UI));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698