Add webapp homescreen shortcut when WebAPK install fails

chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
@@ skipping 357 matching lines @@
     // TODO(mgiuca): Send the appinstalled event for WebAPKs (but just removing
     // this check won't be sufficient).
     if (!is_webapk_)
       weak_manager_->OnInstall();
   }
 }
 
 void AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished(
     bool success,
     const std::string& webapk_package_name) {
-  JNIEnv* env = base::android::AttachCurrentThread();
   if (!success) {
-    DVLOG(1) << "The WebAPK installation failed.";
-    Java_AppBannerInfoBarDelegateAndroid_showWebApkInstallFailureToast(env);
-    webapk::TrackInstallEvent(webapk::INSTALL_FAILED);
-    if (infobar())
-      infobar()->RemoveSelf();
+    OnWebApkInstallFailed();
     return;
   }
-
   UpdateStateForInstalledWebAPK(webapk_package_name);
   webapk::TrackInstallDuration(timer_->Elapsed());
   timer_.reset();
   webapk::TrackInstallEvent(webapk::INSTALL_COMPLETED);
 }
 
+void AppBannerInfoBarDelegateAndroid::OnWebApkInstallFailed() {
+  DVLOG(1) << "The WebAPK installation failed.";
+  webapk::TrackInstallEvent(webapk::INSTALL_FAILED);
+
+  if (infobar())

[dominickn, 2017/03/02 04:14:49]

Pretty sure it should be if (!infobar())

+    return;
+
+  content::WebContents* web_contents =
+      InfoBarService::WebContentsFromInfoBar(infobar());
+  // Add webapp shortcut to the homescreen.
+  // TODO(pkotwicz): Only add webapp shortcut to the homescreen if
+  // WebAPK install did not timeout. If the WebAPK install timed out
+  // it is possible that Google Play is taking a long time and will
+  // eventually installs the WebAPK.
+  ShortcutHelper::AddToLauncherWithSkBitmap(web_contents, *shortcut_info_,
+                                            *icon_.get());
+
+  infobar()->RemoveSelf();
+}
+
 void AppBannerInfoBarDelegateAndroid::TrackWebApkInstallationDismissEvents(
     InstallState install_state) {
   if (install_state == INSTALL_NOT_STARTED) {
     webapk::TrackInstallEvent(webapk::INFOBAR_DISMISSED_BEFORE_INSTALLATION);
   } else if (install_state == INSTALLING) {
     webapk::TrackInstallEvent(webapk::INFOBAR_DISMISSED_DURING_INSTALLATION);
   } else if (install_state == INSTALLED) {
     // If WebAPK is installed from this banner, TrackInstallEvent() is called in
     // OnWebApkInstallFinished().
     if (is_webapk_already_installed_)
@@ skipping 63 matching lines @@
 
   TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
   return true;
 }
 
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners