third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl - Issue 2721163002: Add support for RTCConfiguration.iceCandidatePoolSize.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl

Issue 2721163002: Add support for RTCConfiguration.iceCandidatePoolSize. (Closed)

Patch Set: Adding back log statement for test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html ('K') | « third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/webrtc-pc/#rtcicetransportpolicy-enum	5 // https://w3c.github.io/webrtc-pc/#rtcicetransportpolicy-enum

6	6

7 // TODO(foolip): The spec does not have the "none" value.	7 // TODO(foolip): The spec does not have the "none" value.

8 // https://crbug.com/659134	8 // https://crbug.com/659134

9 enum RTCIceTransportPolicy {	9 enum RTCIceTransportPolicy {

10 "none",	10 "none",

(...skipping 23 matching lines...) Expand all Loading...
34 // TODO(foolip): \|iceTransportPolicy\| default should be "all", but it is	34 // TODO(foolip): \|iceTransportPolicy\| default should be "all", but it is

35 // omitted to allow fallback to \|iceTransports\| if not specified.	35 // omitted to allow fallback to \|iceTransports\| if not specified.

36 RTCIceTransportPolicy iceTransportPolicy;	36 RTCIceTransportPolicy iceTransportPolicy;

37 // TODO(foolip): \|iceTransports\| is not in the spec.	37 // TODO(foolip): \|iceTransports\| is not in the spec.

38 // https://crbug.com/659131	38 // https://crbug.com/659131

39 RTCIceTransportPolicy iceTransports;	39 RTCIceTransportPolicy iceTransports;

40 RTCBundlePolicy bundlePolicy = "balanced";	40 RTCBundlePolicy bundlePolicy = "balanced";

41 RTCRtcpMuxPolicy rtcpMuxPolicy = "require";	41 RTCRtcpMuxPolicy rtcpMuxPolicy = "require";

42 // TODO(foolip): DOMString peerIdentity;	42 // TODO(foolip): DOMString peerIdentity;

43 sequence<RTCCertificate> certificates;	43 sequence<RTCCertificate> certificates;

44 // TODO(foolip): unsigned short iceCandidatePoolSize = 0;	44 [EnforceRange] unsigned short iceCandidatePoolSize = 0;
	foolip 2017/03/02 12:38:30 The spec doesn't use [EnforceRage] for this. If it The spec doesn't use [EnforceRage] for this. If it should, can you file a spec issue? Taylor_Brandstetter 2017/03/02 21:57:01 Done: https://github.com/w3c/webrtc-pc/issues/1048 Show quoted text On 2017/03/02 12:38:30, foolip wrote: > The spec doesn't use [EnforceRage] for this. If it should, can you file a spec > issue? Done: https://github.com/w3c/webrtc-pc/issues/1048
45 };	45 };

OLD	NEW