Remove ash_util namespace

chrome/browser/ui/ash/ash_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/ash_util.h"
 
 #include "ash/common/accelerators/accelerator_controller.h"
 #include "ash/common/mojo_interface_factory.h"
 #include "ash/common/wm_shell.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/ash/ash_init.h"

[stevenjb, 2017/03/01 17:42:32]

This dependency appears to be unnecessary and it looks like the rest of the code
can move to src/ash.

[James Cook, 2017/03/01 18:11:15]

I am uncertain if IsRunningInMash() as written below would work if called from
code in src/ash. src/ash has its own WmShell::IsRunningInMash(). sky@ would know
better.

Likewise ash doesn't want to have content/ DEPS.

I think these utilities should be kept in //chrome.

[sky, 2017/03/01 20:50:15]

tl;dr this check should be in the client code, not ash.

Going forward the only dependency we want chrome to have on ash is
ash/public/cpp. Think of that as the client library for ash, by which I mean any
clients that need to do ash specific things use the ash client library. Given
that, does IsRunningInMash makes sense in ash's public library? I view that as
linking with a bunch of code and then having a function in that code,
AmIUsingYou()? That's weird. The code consuming the client library should know
whether it is actually using the client library, not the client library itself.
So, IsRunningInMash should be here.
Agreed.

 #include "content/public/common/service_names.mojom.h"
 #include "services/service_manager/public/cpp/interface_registry.h"
 #include "services/service_manager/public/cpp/service.h"
 #include "services/service_manager/public/interfaces/interface_provider_spec.mojom.h"
 #include "services/service_manager/runner/common/client_util.h"
 #include "ui/aura/window_event_dispatcher.h"
 
-namespace ash_util {
-
 namespace {
 
 class EmbeddedAshService : public service_manager::Service {
  public:
   explicit EmbeddedAshService(
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
       : task_runner_(task_runner),
         interfaces_(service_manager::mojom::kServiceManager_ConnectorSpec) {}
   ~EmbeddedAshService() override {}
 
@@ skipping 31 matching lines @@
 }
 
 bool IsAcceleratorDeprecated(const ui::Accelerator& accelerator) {
   // When running in mash the browser doesn't handle ash accelerators.
   if (IsRunningInMash())
     return false;
 
   return ash::WmShell::Get()->accelerator_controller()->IsDeprecated(
       accelerator);
 }
-
-}  // namespace ash_util