Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2721153002: DevTools: render continue-to-location decoration as an arrow. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 /** 608 /**
609 * @param {!Array<!SDK.DebuggerModel.Location>} locations 609 * @param {!Array<!SDK.DebuggerModel.Location>} locations
610 * @this {Sources.JavaScriptSourceFrame} 610 * @this {Sources.JavaScriptSourceFrame}
611 */ 611 */
612 function renderLocations(locations) { 612 function renderLocations(locations) {
613 var bookmarks = this.textEditor.bookmarks( 613 var bookmarks = this.textEditor.bookmarks(
614 this.textEditor.fullRange(), Sources.JavaScriptSourceFrame.continueToL ocationDecorationSymbol); 614 this.textEditor.fullRange(), Sources.JavaScriptSourceFrame.continueToL ocationDecorationSymbol);
615 bookmarks.map(bookmark => bookmark.clear()); 615 bookmarks.map(bookmark => bookmark.clear());
616 616
617 for (var location of locations) { 617 for (var location of locations) {
618 var icon = UI.Icon.create('smallicon-green-ball'); 618 var icon = UI.Icon.create('smallicon-green-arrow');
619 icon.classList.add('cm-continue-to-location'); 619 icon.classList.add('cm-continue-to-location');
620 icon.addEventListener('click', location.continueToLocation.bind(location )); 620 icon.addEventListener('click', location.continueToLocation.bind(location ));
621 icon.addEventListener('mousemove', hidePopoverAndConsumeEvent.bind(this) ); 621 icon.addEventListener('mousemove', hidePopoverAndConsumeEvent.bind(this) );
622 this.textEditor.addBookmark( 622 this.textEditor.addBookmark(
623 location.lineNumber, location.columnNumber, icon, 623 location.lineNumber, location.columnNumber, icon,
624 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol); 624 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol);
625 } 625 }
626 } 626 }
627 627
628 /** 628 /**
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 return; 1441 return;
1442 this.bookmark.clear(); 1442 this.bookmark.clear();
1443 this.bookmark = null; 1443 this.bookmark = null;
1444 } 1444 }
1445 }; 1445 };
1446 1446
1447 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); 1447 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark');
1448 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); 1448 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element');
1449 1449
1450 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark'); 1450 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698