Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 272113002: Revert of Enable the ninja parsing code all the time. (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews, erikwright+watch_chromium.org, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Revert of Enable the ninja parsing code all the time. (https://codereview.chromium.org/270333002/) Reason for revert: Speculative revert. Maybe the cause of various bot failures involving "A .isolate file is required" Logs: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/10820 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/39788 Snippet from Linux Tests log: /usr/bin/python /mnt/data/b/build/slave/Linux_Tests/build/src/tools/swarming_client/isolate.py run --isolated /mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/interactive_ui_tests.isolated -v -- --no-cr --test-launcher-bot-mode --gtest_output=xml:/mnt/data/b/build/slave/Linux_Tests/build/gtest-results/interactive_ui_tests/interactive_ui_tests.xml --test-launcher-summary-output=/tmp/tmpldQYtj [------ Swarming Error ------] A .isolate file is required. Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/swarming_client/isolate.py", line 1516, in main return dispatcher.execute(OptionParserIsolate(version=__version__), argv) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/swarming_client/third_party/depot_tools/subcommand.py", line 242, in execute return command(parser, args[1:]) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/swarming_client/isolate.py", line 1251, in CMDrun options, os.getcwd(), None, options.skip_refresh) File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/swarming_client/isolate.py", line 863, in load_complete_state raise ExecutionError('A .isolate file is required.') ExecutionError: A .isolate file is required. Original issue's description: > isolate_driver: Enable ninja parsing code all the time. > > Split the ninja parsing code in its own file so that isolate_driver is focused > on .isolate management. > > - This removes the need to specify the majority of binary runtime dependencies. > Sadly, this means a few unrelated binaries are now pulled in, for example d8, > libvpx_obj_int_extract and tls_edit. That's a maintenance/performance trade > off. > - Removed some dependencies for unit_tests.isolate to ensure this works. > > R=vadimsh@chromium.org > BUG=368543 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269140 TBR=vadimsh@chromium.org,maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG=368543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -319 lines) Patch
M base/base_unittests.isolate View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 3 chunks +7 lines, -0 lines 0 comments Download
M tools/isolate_driver.py View 3 chunks +158 lines, -6 lines 0 comments Download
D tools/ninja_parser.py View 1 chunk +0 lines, -313 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
Created Revert of Enable the ninja parsing code all the time.
6 years, 7 months ago (2014-05-09 03:30:26 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-05-09 03:31:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/272113002/1
6 years, 7 months ago (2014-05-09 03:33:15 UTC) #3
commit-bot: I haz the power
Change committed as 269163
6 years, 7 months ago (2014-05-09 03:39:31 UTC) #4
M-A Ruel
6 years, 7 months ago (2014-05-09 10:13:16 UTC) #5
Message was sent while issue was closed.
Thanks, I'll figure this out.

Powered by Google App Engine
This is Rietveld 408576698