Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7146)

Unified Diff: chrome/test/data/extensions/api_test/desktop_capture/test.js

Issue 2721113002: getUserMedia: handle the device starting status report. (Closed)
Patch Set: address comments on PS#3 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/desktop_capture/test.js
diff --git a/chrome/test/data/extensions/api_test/desktop_capture/test.js b/chrome/test/data/extensions/api_test/desktop_capture/test.js
index bdf3131048a12721601097d02ba957c1cfdbf0f5..8349380973b1646424519cd1e42b22123b05bc81 100644
--- a/chrome/test/data/extensions/api_test/desktop_capture/test.js
+++ b/chrome/test/data/extensions/api_test/desktop_capture/test.js
@@ -123,27 +123,9 @@ chrome.test.runTests([
chrome.test.succeed();
},
- // For the following six, they all request audio track. Based on user's
- // permission and the source type, it may or may not actually get the audio
- // track.
- // In detail:
- // 1. We cannot support audio for Window share;
- // 2. We can support audio for Tab share;
- // 3. We can support audio for Screen share on Windows;
- // 4. We can support audio for Screen Share on ChromeOS if USE_CRAS is on;
- // 5. To actually get audio track, user permission is always necessary;
- // 6. To actually get audio track, getUserMedia() should set audio
- // constraint.
- function tabShareWithAudioPermissionGetStream() {
- chrome.desktopCapture.chooseDesktopMedia(
- ["tab", "audio"], onPickerResult.bind(undefined, 1));
- },
-
- function windowShareWithAudioPermissionGetStream() {
- chrome.desktopCapture.chooseDesktopMedia(
- ["window", "audio"], onPickerResult.bind(undefined, 0));
- },
-
+ // Only screenShare can be tested as below, because "chooseDesktopMedia" will
+ // return fake source id to tab/windowShare, with which tab/window catpure
+ // can't be started successfully.
function screenShareWithAudioPermissionGetStream() {
chrome.desktopCapture.chooseDesktopMedia(
["screen", "audio"],
@@ -151,16 +133,6 @@ chrome.test.runTests([
expected_audio_tracks_for_screen_share));
},
- function tabShareWithoutAudioPermissionGetStream() {
- chrome.desktopCapture.chooseDesktopMedia(
- ["tab", "audio"], onPickerResult.bind(undefined, 0));
- },
-
- function windowShareWithoutAudioPermissionGetStream() {
- chrome.desktopCapture.chooseDesktopMedia(
- ["window", "audio"], onPickerResult.bind(undefined, 0));
- },
-
function screenShareWithoutAudioPermissionGetStream() {
chrome.desktopCapture.chooseDesktopMedia(
["screen", "audio"], onPickerResult.bind(undefined, 0));

Powered by Google App Engine
This is Rietveld 408576698