Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc

Issue 2721113002: getUserMedia: handle the device starting status report. (Closed)
Patch Set: address comments on PS#3 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
index 3d1209869919b8fe2702935e0660a776a2b1b188..8ee3d8762c05863bdc8cdd791b05f0c9b81a2563 100644
--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
@@ -206,23 +206,12 @@ IN_PROC_BROWSER_TEST_F(DesktopCaptureApiTest, MAYBE_ChooseDesktopMedia) {
webrtc::kFullDesktopScreenId)},
// cancelDialog()
{true, true, false, false, content::DesktopMediaID(), true},
- // tabShareWithAudioGetStream()
- {false, false, true, true,
- content::DesktopMediaID(content::DesktopMediaID::TYPE_WEB_CONTENTS, 0,
- true)},
- // windowShareWithAudioGetStream()
- {false, true, false, true,
- content::DesktopMediaID(content::DesktopMediaID::TYPE_WINDOW, 0, true)},
+
// screenShareWithAudioGetStream()
{true, false, false, true,
content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
webrtc::kFullDesktopScreenId, true)},
- // tabShareWithoutAudioGetStream()
miu 2017/03/06 22:37:33 I'm worried about these deletions. Instead, can we
braveyao 2017/03/08 22:02:51 Done.
- {false, false, true, true,
- content::DesktopMediaID(content::DesktopMediaID::TYPE_WEB_CONTENTS, 0)},
- // windowShareWithoutAudioGetStream()
- {false, true, false, true,
- content::DesktopMediaID(content::DesktopMediaID::TYPE_WINDOW, 0)},
+
// screenShareWithoutAudioGetStream()
{true, false, false, true,
content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,

Powered by Google App Engine
This is Rietveld 408576698