getUserMedia: handle the device starting status report.

chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <array>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 188 matching lines @@
       // chooseMediaAndGetStream()
       {true, true, false, false,
        content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
                                webrtc::kFullDesktopScreenId)},
       // chooseMediaAndTryGetStreamWithInvalidId()
       {true, true, false, false,
        content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
                                webrtc::kFullDesktopScreenId)},
       // cancelDialog()
       {true, true, false, false, content::DesktopMediaID(), true},
+
+      // screenShareWithAudioGetStream()
+      {true, false, false, true,
+       content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
+                               webrtc::kFullDesktopScreenId, true)},
+
+      // screenShareWithoutAudioGetStream()
+      {true, false, false, true,
+       content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
+                               webrtc::kFullDesktopScreenId)},
+
+      /**

[Sergey Ulanov, 2017/03/14 19:43:34]

please use C++ style comments (//..) to comment the test. 
Otherwise it's harder to see in review and in git-diff that the test is
commented.
Also that would allow to avoid moving any tests

[braveyao, 2017/03/14 23:42:08]

Done.

+       * Below test cases are commented out because getUserMedia will fail due
+       * to the fake source id currently.
+       * TODO(braveyao): get these cases working again. http://crbug.com/699201
       // tabShareWithAudioGetStream()
       {false, false, true, true,
        content::DesktopMediaID(content::DesktopMediaID::TYPE_WEB_CONTENTS, 0,
                                true)},
       // windowShareWithAudioGetStream()
       {false, true, false, true,
        content::DesktopMediaID(content::DesktopMediaID::TYPE_WINDOW, 0, true)},
-      // screenShareWithAudioGetStream()
-      {true, false, false, true,
-       content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
-                               webrtc::kFullDesktopScreenId, true)},
       // tabShareWithoutAudioGetStream()
       {false, false, true, true,
        content::DesktopMediaID(content::DesktopMediaID::TYPE_WEB_CONTENTS, 0)},
       // windowShareWithoutAudioGetStream()
       {false, true, false, true,
        content::DesktopMediaID(content::DesktopMediaID::TYPE_WINDOW, 0)},
-      // screenShareWithoutAudioGetStream()
-      {true, false, false, true,
-       content::DesktopMediaID(content::DesktopMediaID::TYPE_SCREEN,
-                               webrtc::kFullDesktopScreenId)},
+       **/
   };
   picker_factory_.SetTestFlags(test_flags, arraysize(test_flags));
   ASSERT_TRUE(RunExtensionTest("desktop_capture")) << message_;
 }
 
 // Test is flaky http://crbug.com/301887.
 IN_PROC_BROWSER_TEST_F(DesktopCaptureApiTest, DISABLED_Delegation) {
   // Initialize test server.
   base::FilePath test_data;
   EXPECT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_data));
@@ skipping 46 matching lines @@
   EXPECT_TRUE(result);
   EXPECT_TRUE(test_flags[2].picker_created);
   EXPECT_FALSE(test_flags[2].picker_deleted);
 
   web_contents->Close();
   destroyed_watcher.Wait();
   EXPECT_TRUE(test_flags[2].picker_deleted);
 }
 
 }  // namespace extensions