[NTP::Downloads] Scale up type based icons.

chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.download;
 
 import android.app.Activity;
 import android.app.PendingIntent;
 import android.content.ActivityNotFoundException;
 import android.content.Context;
@@ skipping 631 matching lines @@
         } else {
             resourceId = stringSet[2];
             bytesInCorrectUnits = bytes / (float) BYTES_PER_GIGABYTE;
         }
 
         return context.getResources().getString(resourceId, bytesInCorrectUnits);
     }
 
     /**
      * Abbreviate a file name into a given number of characters with ellipses.
-     * e.g. thisisaverylongfilename.txt => thisisave....txt
-     * @param fileName File name to abbreviate
-     * @param limit Character limit
-     * @return Abbreviated file name
+     * e.g. thisisaverylongfilename.txt => thisisave....txt.

[gone, 2017/02/28 18:46:25]

I'd remove this period; it makes the example ambiguous

[vitaliii, 2017/03/01 09:08:30]

Done.

"thisisaverylongfilename.txt" => "thisisave....txt".

+     * @param fileName File name to abbreviate.
+     * @param limit Character limit.
+     * @return Abbreviated file name.
      */
     public static String getAbbreviatedFileName(String fileName, int limit) {
         assert limit >= 1;  // Abbreviated file name should at least be 1 characters (a...)
 
         if (TextUtils.isEmpty(fileName)) return fileName;
 
         if (fileName.length() <= limit) return fileName;
 
         // Find the file name extension
         int index = fileName.lastIndexOf(".");
         int extensionLength = fileName.length() - index;
 
         // If the extension is too long, just use truncate the string from beginning.
         if (extensionLength >= limit) {
             return fileName.substring(0, limit) + ELLIPSIS;
         }
         int remainingLength = limit - extensionLength;
         return fileName.substring(0, remainingLength) + ELLIPSIS + fileName.substring(index);
     }
 
     /**
      * Return an icon for a given file type.
-     * @param fileType Type of the file as returned by DownloadFilter
-     * @return Resource ID of the corresponding icon
+     * @param fileType Type of the file as returned by DownloadFilter.
+     * @param sizeDp Size in device pixels of the returned icon.
+     * @return Resource ID of the corresponding icon.
      */
-    public static int getIconResId(int fileType) {
+    public static int getIconResId(int fileType, int sizeDp) {
+        assert sizeDp == 24 || sizeDp == 36;

[dgn, 2017/02/28 18:30:16]

nit: use 2 @IntDef constants to make clear through the API which values are
supported?

[vitaliii, 2017/03/01 09:08:30]

Done.

         switch (fileType) {
             case DownloadFilter.FILTER_PAGE:
-                return R.drawable.ic_drive_site_white_24dp;
+                return sizeDp == 24 ? R.drawable.ic_drive_site_white_24dp
+                                    : R.drawable.ic_drive_site_white_36dp;
             case DownloadFilter.FILTER_VIDEO:
-                return R.drawable.ic_play_arrow_white_24dp;
+                return sizeDp == 24 ? R.drawable.ic_play_arrow_white_24dp
+                                    : R.drawable.ic_play_arrow_white_36dp;
             case DownloadFilter.FILTER_AUDIO:
-                return R.drawable.ic_music_note_white_24dp;
+                return sizeDp == 24 ? R.drawable.ic_music_note_white_24dp
+                                    : R.drawable.ic_music_note_white_36dp;
             case DownloadFilter.FILTER_IMAGE:
-                return R.drawable.ic_image_white_24dp;
+                return sizeDp == 24 ? R.drawable.ic_image_white_24dp
+                                    : R.drawable.ic_image_white_36dp;
             case DownloadFilter.FILTER_DOCUMENT:
-                return R.drawable.ic_drive_text_white_24dp;
+                return sizeDp == 24 ? R.drawable.ic_drive_text_white_24dp
+                                    : R.drawable.ic_drive_text_white_36dp;
             default:
-                return R.drawable.ic_drive_file_white_24dp;
+                return sizeDp == 24 ? R.drawable.ic_drive_file_white_24dp
+                                    : R.drawable.ic_drive_text_white_36dp;
         }
     }
 
     /**
      * Return a background color for the file type icon.
-     * @param context Context from which to extract the resources
-     * @return Background color
+     * @param context Context from which to extract the resources.
+     * @return Background color.
      */
     public static int getIconBackgroundColor(Context context) {
         return ApiCompatibilityUtils.getColor(context.getResources(), R.color.light_active_color);
     }
 
     /**
      * Return a foreground color list for the file type icon.
-     * @param context Context from which to extract the resources
-     * @return a foreground color list
+     * @param context Context from which to extract the resources.
+     * @return a foreground color list.
      */
     public static ColorStateList getIconForegroundColorList(Context context) {
         return ApiCompatibilityUtils.getColorStateList(
                 context.getResources(), R.color.white_mode_tint);
     }
 
     private static boolean isMimeTypeVideo(String mimeType) {
         if (TextUtils.isEmpty(mimeType)) return false;
 
         String[] pieces = mimeType.split(MIME_TYPE_DELIMITER);
         if (pieces.length != 2) return false;
 
         return MIME_TYPE_VIDEO.equals(pieces[0]);
     }
 }