Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: ios/web/web_state/web_state_impl.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_state_impl.mm
diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm
index 960892c0b10ace1bcf806756c106bb0dddaf69a7..aeec703cbbcd8b7a27203e96b5c61163bb0b441f 100644
--- a/ios/web/web_state/web_state_impl.mm
+++ b/ios/web/web_state/web_state_impl.mm
@@ -47,11 +47,8 @@ std::unique_ptr<WebState> WebState::Create(const CreateParams& params) {
std::unique_ptr<WebStateImpl> web_state(
new WebStateImpl(params.browser_state));
- // Initialized the new session.
- NSString* window_name = nil;
- BOOL opened_by_dom = NO;
- web_state->GetNavigationManagerImpl().InitializeSession(window_name,
- opened_by_dom);
+ // Initialize the new session.
+ web_state->GetNavigationManagerImpl().InitializeSession(NO);
Eugene But (OOO till 7-30) 2017/02/28 16:04:09 Could you please either leave opened_by_dom locakl
sdefresne 2017/02/28 17:41:07 Done.
// This std::move is required to compile with the version of clang shipping
// with Xcode 8.0+. Evalute whether the issue is fixed once a new version of

Powered by Google App Engine
This is Rietveld 408576698