Chromium Code Reviews| Index: ios/chrome/browser/tabs/tab.h |
| diff --git a/ios/chrome/browser/tabs/tab.h b/ios/chrome/browser/tabs/tab.h |
| index 62b5e39acadf70e558f4113c6e828305d251b188..df5c4afb5caaf853a7a219de4df08d9ef1a31dcf 100644 |
| --- a/ios/chrome/browser/tabs/tab.h |
| +++ b/ios/chrome/browser/tabs/tab.h |
| @@ -114,7 +114,6 @@ extern NSString* const kProxyPassthroughHeaderValue; |
| @property(nonatomic, readonly) NSString* originalTitle; |
| @property(nonatomic, readonly) NSString* urlDisplayString; |
| -@property(nonatomic, readonly) NSString* windowName; |
| // ID associated with this tab. |
| @property(nonatomic, readonly) NSString* tabId; |
| @@ -165,11 +164,10 @@ extern NSString* const kProxyPassthroughHeaderValue; |
| // Creates a new tab with the given state. |opener| is nil unless another tab |
| // is conceptually the parent of this tab. |openedByDOM| is YES if the page was |
| // opened by DOM. |model| and |browserState| must not be nil. |
| -- (instancetype)initWithWindowName:(NSString*)windowName |
| - opener:(Tab*)opener |
| - openedByDOM:(BOOL)openedByDOM |
| - model:(TabModel*)parentModel |
| - browserState:(ios::ChromeBrowserState*)browserState; |
| +- (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState |
| + opener:(Tab*)opener |
| + openedByDOM:(BOOL)openedByDOM |
| + model:(TabModel*)parentModel; |
| // Create a new tab with given web state and tab model. All must be non-nil. |
| - (instancetype)initWithWebState:(std::unique_ptr<web::WebState>)webState |
| @@ -186,7 +184,7 @@ extern NSString* const kProxyPassthroughHeaderValue; |
| // Creates a new Tab instance loading |url| with |transition|, configured |
| // with no TabModel. |opener| may be nil, and behaves exactly as for |
| -// -initWithWindowName:opener:model:browserState:. |
| +// -initWithBrowserState:opener:model. |
|
Eugene But (OOO till 7-30)
2017/02/28 16:04:09
initWithBrowserState:opener:openedByDOM:model: ?
sdefresne
2017/02/28 17:41:07
Done.
|
| // |configuration| is a block that will be run before |url| starts loading, |
| // and is the correct place to set properties and delegates on the tab. |
| // Calling code must take ownership of the tab -- this is particularly important |