Remove windowName from CRWSessionController.

ios/chrome/browser/ui/browser_view_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 
 #import <AssetsLibrary/AssetsLibrary.h>
 #import <MobileCoreServices/MobileCoreServices.h>
 #import <PassKit/PassKit.h>
 #import <Photos/Photos.h>
@@ skipping 2025 matching lines @@
   params.transition_type = transition;
   if (postData) {
     // Extract the content type and post params from |postData| and add them
     // to the load params.
     NSString* contentType = base::SysUTF8ToNSString(postData->first);
     NSData* data = [NSData dataWithBytes:(void*)postData->second.data()
                                   length:postData->second.length()];
     params.post_data.reset([data retain]);
     params.extra_headers.reset([@{ @"Content-Type" : contentType } retain]);
   }
-  Tab* tab = [_model insertOrUpdateTabWithLoadParams:params
-                                          windowName:nil
-                                              opener:nil
-                                         openedByDOM:NO
-                                             atIndex:position
-                                        inBackground:NO];
+  Tab* tab = [_model insertTabWithLoadParams:params
+                                      opener:nil
+                                 openedByDOM:NO
+                                     atIndex:position
+                                inBackground:NO];
   return tab;
 }
 
 // Whether the given tab's url begins with the chrome prefix.
 - (BOOL)isTabNativePage:(Tab*)tab {
   return tab && tab.url.SchemeIs(kChromeUIScheme);
 }
 
 - (void)expectNewForegroundTab {
   _expectingForegroundTab = YES;
@@ skipping 288 matching lines @@
 }
 
 #pragma mark - CRWWebStateDelegate methods.
 
 - (web::WebState*)webState:(web::WebState*)webState
          openURLWithParams:(const web::WebState::OpenURLParams&)params {
   switch (params.disposition) {
     case WindowOpenDisposition::NEW_FOREGROUND_TAB:
     case WindowOpenDisposition::NEW_BACKGROUND_TAB: {
       Tab* tab = [[self tabModel]
-          insertOrUpdateTabWithURL:params.url
-                          referrer:params.referrer
-                        transition:params.transition
-                        windowName:nil
-                            opener:LegacyTabHelper::GetTabForWebState(webState)
-                       openedByDOM:NO
-                           atIndex:TabModelConstants::kTabPositionAutomatically
-                      inBackground:(params.disposition ==
-                                    WindowOpenDisposition::NEW_BACKGROUND_TAB)];
+          insertTabWithURL:params.url
+                  referrer:params.referrer
+                transition:params.transition
+                    opener:LegacyTabHelper::GetTabForWebState(webState)
+               openedByDOM:NO
+                   atIndex:TabModelConstants::kTabPositionAutomatically
+              inBackground:(params.disposition ==
+                            WindowOpenDisposition::NEW_BACKGROUND_TAB)];
       return tab.webState;
     }
     case WindowOpenDisposition::CURRENT_TAB: {
       web::NavigationManager::WebLoadParams loadParams(params.url);
       loadParams.referrer = params.referrer;
       loadParams.transition_type = params.transition;
       loadParams.is_renderer_initiated = params.is_renderer_initiated;
       webState->GetNavigationManager()->LoadURLWithParams(loadParams);
       return webState;
     }
     case WindowOpenDisposition::NEW_POPUP: {
       Tab* tab = [[self tabModel]
-          insertOrUpdateTabWithURL:params.url
-                          referrer:params.referrer
-                        transition:params.transition
-                        windowName:nil
-                            opener:LegacyTabHelper::GetTabForWebState(webState)
-                       openedByDOM:YES
-                           atIndex:TabModelConstants::kTabPositionAutomatically
-                      inBackground:NO];
+          insertTabWithURL:params.url
+                  referrer:params.referrer
+                transition:params.transition
+                    opener:LegacyTabHelper::GetTabForWebState(webState)
+               openedByDOM:YES
+                   atIndex:TabModelConstants::kTabPositionAutomatically
+              inBackground:NO];
       return tab.webState;
     }
     default:
       NOTIMPLEMENTED();
       return nullptr;
   };
 }
 
 - (BOOL)webState:(web::WebState*)webState
     handleContextMenu:(const web::ContextMenuParams&)params {
@@ skipping 38 matching lines @@
     if (web::UrlHasWebScheme(link)) {
       web::Referrer referrer([_model currentTab].url, params.referrer_policy);
 
       // Open in New Tab.
       title = l10n_util::GetNSStringWithFixup(
           IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB);
       action = ^{
         Record(ACTION_OPEN_IN_NEW_TAB, isImage, isLink);
         [weakSelf webPageOrderedOpen:link
                             referrer:referrer
-                          windowName:nil
                         inBackground:YES
                             appendTo:kCurrentTab];
       };
       [_contextMenuCoordinator addItemWithTitle:title action:action];
       if (!_isOffTheRecord) {
         // Open in Incognito Tab.
         title = l10n_util::GetNSStringWithFixup(
             IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWINCOGNITOTAB);
         action = ^{
           Record(ACTION_OPEN_IN_INCOGNITO_TAB, isImage, isLink);
           [weakSelf webPageOrderedOpen:link
                               referrer:referrer
-                            windowName:nil
                            inIncognito:YES
                           inBackground:NO
                               appendTo:kCurrentTab];
         };
         [_contextMenuCoordinator addItemWithTitle:title action:action];
       }
     }
     if (link.SchemeIsHTTPOrHTTPS() &&
         reading_list::switches::IsReadingListEnabled()) {
       NSString* innerText = params.link_text;
@@ skipping 41 matching lines @@
           rendererInitiated:YES];
     };
     [_contextMenuCoordinator addItemWithTitle:title action:action];
     // Open Image In New Tab.
     title = l10n_util::GetNSStringWithFixup(
         IDS_IOS_CONTENT_CONTEXT_OPENIMAGENEWTAB);
     action = ^{
       Record(ACTION_OPEN_IMAGE_IN_NEW_TAB, isImage, isLink);
       [weakSelf webPageOrderedOpen:imageUrl
                           referrer:referrer
-                        windowName:nil
                       inBackground:true
                           appendTo:kCurrentTab];
     };
     [_contextMenuCoordinator addItemWithTitle:title action:action];
 
     TemplateURLService* service =
         ios::TemplateURLServiceFactory::GetForBrowserState(_browserState);
     TemplateURL* defaultURL = service->GetDefaultSearchProvider();
     if (defaultURL && !defaultURL->image_url().empty() &&
         defaultURL->image_url_ref().IsValid(service->search_terms_data())) {
@@ skipping 815 matching lines @@
 }
 
 - (void)hidePageInfoPopupForView:(UIView*)sourceView {
   [_pageInfoController dismiss];
   _pageInfoController.reset();
 }
 
 - (void)showSecurityHelpPage {
   [self webPageOrderedOpen:GURL(kPageInfoHelpCenterURL)
                   referrer:web::Referrer()
-                windowName:nil
               inBackground:NO
                   appendTo:kCurrentTab];
   [self hidePageInfoPopupForView:nil];
 }
 
 - (void)showTabHistoryPopupForBackwardHistory {
   DCHECK(self.visible || self.dismissingModal);
 
   // Dismiss the omnibox (if open).
   [_toolbarController cancelOmniboxEdit];
@@ skipping 244 matching lines @@
     urlToLoad = [_preloadController prefetchedURL];
   }
 
   [_preloadController cancelPrerender];
 
   // Some URLs are not allowed while in incognito.  If we are in incognito and
   // load a disallowed URL, instead create a new tab not in the incognito state.
   if (_isOffTheRecord && !IsURLAllowedInIncognito(url)) {
     [self webPageOrderedOpen:url
                     referrer:web::Referrer()
-                  windowName:nil
                  inIncognito:NO
                 inBackground:NO
                     appendTo:kCurrentTab];
     return;
   }
 
   web::NavigationManager::WebLoadParams params(urlToLoad);
   params.referrer = referrer;
   params.transition_type = transition;
   params.is_renderer_initiated = rendererInitiated;
@@ skipping 18 matching lines @@
     // Ensure full screen height is updated.
     Tab* currentTab = [_model currentTab];
     BOOL visible = self.isToolbarOnScreen;
     [currentTab updateFullscreenWithToolbarVisible:visible];
   }
 }
 
 // Load a new URL on a new page/tab.
 - (void)webPageOrderedOpen:(const GURL&)URL
                   referrer:(const web::Referrer&)referrer
-                windowName:(NSString*)windowName
               inBackground:(BOOL)inBackground
                   appendTo:(OpenPosition)appendTo {
   Tab* adjacentTab = nil;
   if (appendTo == kCurrentTab)
     adjacentTab = [_model currentTab];
-  [_model insertOrUpdateTabWithURL:URL
-                          referrer:referrer
-                        transition:ui::PAGE_TRANSITION_LINK
-                        windowName:windowName
-                            opener:adjacentTab
-                       openedByDOM:NO
-                           atIndex:TabModelConstants::kTabPositionAutomatically
-                      inBackground:inBackground];
+  [_model insertTabWithURL:URL
+                  referrer:referrer
+                transition:ui::PAGE_TRANSITION_LINK
+                    opener:adjacentTab
+               openedByDOM:NO
+                   atIndex:TabModelConstants::kTabPositionAutomatically
+              inBackground:inBackground];
 }
 
 - (void)webPageOrderedOpen:(const GURL&)url
                   referrer:(const web::Referrer&)referrer
-                windowName:(NSString*)windowName
                inIncognito:(BOOL)inIncognito
               inBackground:(BOOL)inBackground
                   appendTo:(OpenPosition)appendTo {
   if (inIncognito == _isOffTheRecord) {
     [self webPageOrderedOpen:url
                     referrer:referrer
-                  windowName:windowName
                 inBackground:inBackground
                     appendTo:appendTo];
     return;
   }
   // When sending an open command that switches modes, ensure the tab
   // ends up appended to the end of the model, not just next to what is
   // currently selected in the other mode. This is done with the |append|
   // parameter.
   base::scoped_nsobject<OpenUrlCommand> command([[OpenUrlCommand alloc]
        initWithURL:url
           referrer:web::Referrer()  // Strip referrer when switching modes.
-        windowName:windowName
        inIncognito:inIncognito
       inBackground:inBackground
           appendTo:kLastTab]);
   [self chromeExecuteCommand:command];
 }
 
 - (void)loadSessionTab:(const sessions::SessionTab*)sessionTab {
   [[_model currentTab] loadSessionTab:sessionTab];
 }
 
@@ skipping 413 matching lines @@
     // If no view controllers are presented, we should be ok with dispatching
     // the completion block directly.
     dispatch_async(dispatch_get_main_queue(), completion);
   }
 }
 
 - (void)showHelpPage {
   GURL helpUrl(l10n_util::GetStringUTF16(IDS_IOS_TOOLS_MENU_HELP_URL));
   [self webPageOrderedOpen:helpUrl
                   referrer:web::Referrer()
-                windowName:nil
               inBackground:NO
                   appendTo:kCurrentTab];
 }
 
 - (void)enableDesktopUserAgent {
   [[_model currentTab] enableDesktopUserAgent];
   [[_model currentTab] reloadForDesktopUserAgent];
 }
 
 - (void)resetAllWebViews {
@@ skipping 191 matching lines @@
     if (!strongTab)
       return;
     if (![result isKindOfClass:[NSString class]])
       result = @"Not an HTML page";
     std::string base64HTML;
     base::Base64Encode(base::SysNSStringToUTF8(result), &base64HTML);
     GURL URL(std::string("data:text/plain;charset=utf-8;base64,") + base64HTML);
     web::Referrer referrer([strongTab url], web::ReferrerPolicyDefault);
 
     [[weakSelf tabModel]
-        insertOrUpdateTabWithURL:URL
-                        referrer:referrer
-                      transition:ui::PAGE_TRANSITION_LINK
-                      windowName:nil
-                          opener:strongTab
-                     openedByDOM:YES
-                         atIndex:TabModelConstants::kTabPositionAutomatically
-                    inBackground:NO];
+        insertTabWithURL:URL
+                referrer:referrer
+              transition:ui::PAGE_TRANSITION_LINK
+                  opener:strongTab
+             openedByDOM:YES
+                 atIndex:TabModelConstants::kTabPositionAutomatically
+            inBackground:NO];
   };
   [webController executeJavaScript:script
                  completionHandler:completionHandlerBlock];
 }
 #endif  // !defined(NDEBUG)
 
 - (void)startVoiceSearch {
   // Delay Voice Search until new tab animations have finished.
   if (_inNewTabAnimation) {
     _startVoiceSearchAfterNewTabAnimation = YES;
@@ skipping 662 matching lines @@
 
 - (UIView*)voiceSearchButton {
   return _voiceSearchButton;
 }
 
 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
   return [self currentLogoAnimationControllerOwner];
 }
 
 @end