Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2720913003: Calls display_configuration_controller to rotate screen in accelerator_controller_delegate_aura (Closed)
Patch Set: Calls display_configuration_controller to rotate screen in accelerator_controller_delegate_aura Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_options_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 77a98b91e8239cfdaa353e7ecb994994ba153a60..00dbf893a5505ac044b996873498106475409fe2 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -757,6 +757,15 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description>
</action>
+<action name="Accel_Rotate_Screen">
+ <owner>wutao@chromium.org</owner>
+ <description>
+ Metric recorded when the user rotate the screen using keyboard shortcut.
Mark P 2017/03/02 00:05:26 nit: rotate -> rotates nit: using -> "using a" or
wutao 2017/03/02 00:26:07 Done.
+ &quot;Accel_Rotate_Window&quot; also included screen rotation accelerator
Mark P 2017/03/02 00:05:26 This sentence is unclear. Did you mean to put (a
wutao 2017/03/02 00:26:07 No. The original rotating screen code used a wrong
+ events prior to M58.
+ </description>
+</action>
+
<action name="Accel_Rotate_Window">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_options_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698