Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/metrics/actions/actions.xml

Issue 2720913003: Calls display_configuration_controller to rotate screen in accelerator_controller_delegate_aura (Closed)
Patch Set: Calls display_configuration_controller to rotate screen in accelerator_controller_delegate_aura Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_options_handler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <!-- 7 <!--
8 This file is a comprehensive list of Chrome user actions along with the owner 8 This file is a comprehensive list of Chrome user actions along with the owner
9 and description for each user action. 9 and description for each user action.
10 10
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
750 <action name="Accel_Restart_PowerButton"> 750 <action name="Accel_Restart_PowerButton">
751 <owner>cschuet@chromium.org</owner> 751 <owner>cschuet@chromium.org</owner>
752 <description>User restarted the device.</description> 752 <description>User restarted the device.</description>
753 </action> 753 </action>
754 754
755 <action name="Accel_Restore_Tab"> 755 <action name="Accel_Restore_Tab">
756 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> 756 <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
757 <description>Please enter the description of this user action.</description> 757 <description>Please enter the description of this user action.</description>
758 </action> 758 </action>
759 759
760 <action name="Accel_Rotate_Screen">
761 <owner>wutao@chromium.org</owner>
762 <description>
763 Metric recorded when the user rotate the screen using keyboard shortcut.
Mark P 2017/03/02 00:05:26 nit: rotate -> rotates nit: using -> "using a" or
wutao 2017/03/02 00:26:07 Done.
764 &quot;Accel_Rotate_Window&quot; also included screen rotation accelerator
Mark P 2017/03/02 00:05:26 This sentence is unclear. Did you mean to put (a
wutao 2017/03/02 00:26:07 No. The original rotating screen code used a wrong
765 events prior to M58.
766 </description>
767 </action>
768
760 <action name="Accel_Rotate_Window"> 769 <action name="Accel_Rotate_Window">
761 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> 770 <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
762 <description>Please enter the description of this user action.</description> 771 <description>Please enter the description of this user action.</description>
763 </action> 772 </action>
764 773
765 <action name="Accel_Scale_Ui_Down"> 774 <action name="Accel_Scale_Ui_Down">
766 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> 775 <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
767 <description>Please enter the description of this user action.</description> 776 <description>Please enter the description of this user action.</description>
768 </action> 777 </action>
769 778
(...skipping 15627 matching lines...) Expand 10 before | Expand all | Expand 10 after
16397 <action name="webapps.AddShortcut.Manifest"> 16406 <action name="webapps.AddShortcut.Manifest">
16398 <owner>mlamouri@chromium.org</owner> 16407 <owner>mlamouri@chromium.org</owner>
16399 <description> 16408 <description>
16400 Shortcut added to the homescreen with a valid Manifest. This action will be 16409 Shortcut added to the homescreen with a valid Manifest. This action will be
16401 recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions 16410 recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions
16402 to keep a trend of whether the webapp also add meta tags. 16411 to keep a trend of whether the webapp also add meta tags.
16403 </description> 16412 </description>
16404 </action> 16413 </action>
16405 16414
16406 </actions> 16415 </actions>
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_options_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698