Calls display_configuration_controller to rotate screen in accelerator_controller_delegate_aura

ash/accelerators/accelerator_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/accelerators/accelerator_controller.h"
 
 #include "ash/common/accelerators/accelerator_table.h"
 #include "ash/common/accessibility_delegate.h"
 #include "ash/common/accessibility_types.h"
 #include "ash/common/ash_switches.h"
@@ skipping 509 matching lines @@
   expected_bounds = wm::GetDefaultLeftSnappedWindowBoundsInParent(
       WmWindow::Get(window.get()));
   EXPECT_EQ(expected_bounds.ToString(), window->bounds().ToString());
   // Snap left again ->> becomes normal.
   GetController()->PerformActionIfEnabled(WINDOW_CYCLE_SNAP_DOCK_LEFT);
   EXPECT_TRUE(window_state->IsNormalStateType());
   EXPECT_FALSE(window_state->IsDocked());
   EXPECT_EQ(normal_bounds.ToString(), window->bounds().ToString());
 }
 
+TEST_F(AcceleratorControllerTest, RotateScreen) {

[afakhry, 2017/02/28 02:51:53]

You probably need to disable this test on mash_unittests.

[wutao, 2017/02/28 20:29:09]

Done.

+  display::Display display = display::Screen::GetScreen()->GetPrimaryDisplay();
+  // Will it alway return a valid primary display?

[bruthig, 2017/02/28 19:11:46]

I believe you can assume GetPrimaryDisplay() will always return a valid value
within AshTestBase tests.  If you really aren't sure, I would use an ASSERT
instead of an early return.

[wutao, 2017/02/28 20:29:09]

Removed the check.

+  if (!display.is_valid())
+    return;
+
+  display::Display::Rotation initial_rotation =
+      GetActiveDisplayRotation(display.id());
+  ui::test::EventGenerator& generator = GetEventGenerator();
+  generator.PressKey(ui::VKEY_BROWSER_REFRESH,
+                     ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN);
+  generator.ReleaseKey(ui::VKEY_BROWSER_REFRESH,
+                       ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN);
+  display::Display::Rotation new_rotation =
+      GetActiveDisplayRotation(display.id());
+  // new_rotation depends on the implementation of GetNextRotation in

[bruthig, 2017/02/28 19:11:47]

nit: replace 'new_rotation' with '|new_rotation|'

[wutao, 2017/02/28 20:29:09]

Done.

+  // accelerator_controller_delegate_aura.cc and the initial rotation

[bruthig, 2017/02/28 19:11:47]

nit:
- You don't need to specifically call out the Aura flavor of the
AcceleratorControllerDelegate.  Just say in general that the next animation is
determined by the AcceleratorControllerDelegate.
- End the sentence with a period.

[wutao, 2017/02/28 20:29:09]

Done.

+  // The best test here is to check they are not equal.

[bruthig, 2017/02/28 19:11:47]

nit: This comment isn't necessary.

[wutao, 2017/02/28 20:29:09]

Done.

+  EXPECT_NE(initial_rotation, new_rotation);
+}
+
 // Test class used for testing docked windows.
 class EnabledDockedWindowsAcceleratorControllerTest
     : public AcceleratorControllerTest {
  public:
   EnabledDockedWindowsAcceleratorControllerTest() = default;
   ~EnabledDockedWindowsAcceleratorControllerTest() override = default;
 
   void SetUp() override {
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         ash::switches::kAshEnableDockedWindows);
@@ skipping 1007 matching lines @@
     // Expect no notifications from the new accelerators.
     EXPECT_TRUE(IsMessageCenterEmpty());
 
     // If the action is LOCK_SCREEN, we must reset the state by unlocking the
     // screen before we proceed testing the rest of accelerators.
     ResetStateIfNeeded();
   }
 }
 
 }  // namespace ash