Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2720893004: VM: Fix simdbc and darkp builds. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix simdbc and darkp builds. - When generating app-aot snapshot we are currently running Kernel isolate in the precompiler mode, which means we can't have field guards enabled. - DBC does not support field guards so flags must be correctly initialized. BUG= TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9fd4823e9da5cf1eb73362ed826e8d6f3cb15e4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/kernel_isolate.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Vyacheslav Egorov (Google)
Hi Ryan, Please take a look.
3 years, 9 months ago (2017-02-28 21:13:25 UTC) #2
Vyacheslav Egorov (Google)
TBRing to unbreak the build
3 years, 9 months ago (2017-02-28 21:20:35 UTC) #4
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-02-28 21:20:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fd4823e9da5cf1eb73362ed826e8d6f3cb15e4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698