Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2720873003: Mark analyzer test as slow. Has timeout on windows. (Closed)

Created:
3 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark analyzer test as slow. Has timeout on windows. Is slowest test in batch even when it doesn't time out. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/2d137a8375b00c1ee4ce09e3f69e54bbbea30c23

Patch Set 1 #

Total comments: 1

Patch Set 2 : Make it Pass, Slow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-02-28 13:06:15 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2720873003/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/2720873003/diff/1/pkg/pkg.status#newcode260 pkg/pkg.status:260: analyzer/test/src/task/strong/inferred_type_test: PASS SLOW Pass, Slow
3 years, 9 months ago (2017-02-28 13:08:37 UTC) #4
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-02-28 13:10:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2d137a8375b00c1ee4ce09e3f69e54bbbea30c23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698