Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: third_party/WebKit/Source/core/mojo/MojoHandle.h

Issue 2720873002: Implements JS bindings for mojo shared buffer. (Closed)
Patch Set: adds layout tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/mojo/MojoHandle.h
diff --git a/third_party/WebKit/Source/core/mojo/MojoHandle.h b/third_party/WebKit/Source/core/mojo/MojoHandle.h
index 78fa9138b91b48b5c6a4a888a89e79b86c7a4235..b822f59648f654468ab199d17c71a0bdd85ff72b 100644
--- a/third_party/WebKit/Source/core/mojo/MojoHandle.h
+++ b/third_party/WebKit/Source/core/mojo/MojoHandle.h
@@ -11,7 +11,10 @@
namespace blink {
class ArrayBufferOrArrayBufferView;
+class MojoCloneBufferHandleFlags;
+class MojoCreateSharedBufferResult;
class MojoHandleSignals;
+class MojoMapBufferResult;
class MojoReadMessageFlags;
class MojoReadMessageResult;
class MojoWatchCallback;
@@ -29,10 +32,16 @@ class MojoHandle final : public GarbageCollectedFinalized<MojoHandle>,
MojoWatcher* watch(ScriptState*,
const MojoHandleSignals&,
MojoWatchCallback*);
+
+ // MessagePipe handle.
MojoResult writeMessage(ArrayBufferOrArrayBufferView&,
const HeapVector<Member<MojoHandle>>&);
void readMessage(const MojoReadMessageFlags&, MojoReadMessageResult&);
+ // SharedBuffer handle.
+ void mapBuffer(unsigned offset, unsigned numBytes, MojoMapBufferResult&);
yzshen1 2017/03/01 23:11:46 Do we also need a way to explicitly release the ma
jbroman 2017/03/01 23:29:37 +1, this is probably a good thing to have. (I thou
alokp 2017/03/01 23:58:34 I am not sure what the usecase for unmap would be
yzshen1 2017/03/02 17:41:08 Because the mappings holds the underlying shared m
+ void clone(const MojoCloneBufferHandleFlags&, MojoCreateSharedBufferResult&);
yzshen1 2017/03/01 23:11:46 Does it make sense to make the names more consiste
alokp 2017/03/01 23:58:34 Please see my other comment. I am happy to change
+
DEFINE_INLINE_TRACE() {}
private:

Powered by Google App Engine
This is Rietveld 408576698