third_party/WebKit/Source/core/mojo/MojoCloneBufferHandleFlags.idl - Issue 2720873002: Implements JS bindings for mojo shared buffer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/mojo/MojoCloneBufferHandleFlags.idl

Issue 2720873002: Implements JS bindings for mojo shared buffer. (Closed)

Patch Set: adds layout tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/mojo/shared-buffer.html ('K') | « third_party/WebKit/Source/core/mojo/Mojo.idl ('k') | third_party/WebKit/Source/core/mojo/MojoCreateSharedBufferResult.idl » ('j') | third_party/WebKit/Source/core/mojo/MojoCreateSharedBufferResult.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 dictionary MojoCloneBufferHandleFlags {

	6 boolean readOnly = false;
	jbroman 2017/03/01 23:29:37 I'd missed the first time through that these can b I'd missed the first time through that these can be read-only. Since we don't have any support for a "read-only" array buffer, the resulting ArrayBuffer (and any views into it) will still seem writable. I assume we'll get a renderer crash (due to memory access violation) if script ever does write it. mojo/edk/js/ already has this issue, so I assume you're aware of/okay with it. (Naturally this means that any script that has access to a mapped buffer must be extremely careful.) yzshen1 2017/03/01 23:33:08 Alok and I chatted about this. Because at the mome Show quoted text On 2017/03/01 23:29:37, jbroman wrote: > I'd missed the first time through that these can be read-only. Since we don't > have any support for a "read-only" array buffer, the resulting ArrayBuffer (and > any views into it) will still seem writable. I assume we'll get a renderer crash > (due to memory access violation) if script ever does write it. > > mojo/edk/js/ already has this issue, so I assume you're aware of/okay with it. > (Naturally this means that any script that has access to a mapped buffer must be > extremely careful.) Alok and I chatted about this. Because at the moment only some special contexts have access to the Mojo APIs (WebUI, layout tests, etc), it should be okay. In the future if we want to expose this to arbitrary web pages, we will need to carefully evaluate its security implication, I think.
	7 };

OLD	NEW