third_party/WebKit/Source/core/mojo/MojoDuplicateBufferHandleOptionsFlags.idl - Issue 2720873002: Implements JS bindings for mojo shared buffer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/mojo/MojoDuplicateBufferHandleOptionsFlags.idl

Issue 2720873002: Implements JS bindings for mojo shared buffer. (Closed)

Patch Set: makes JS API same as C API Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 dictionary MojoDuplicateBufferHandleOptionsFlags {
	jbroman 2017/03/02 20:50:47 nit: I'd just inline this into MojoDuplicateBuffer nit: I'd just inline this into MojoDuplicateBufferHandleOptions. {readOnly: true} seems like it's just as useful as {flags: {readOnly: true}}, but it's shorter, simpler and faster. I see the fact that they're nested in Mojo as an artifact of C vs JS API style. alokp 2017/03/02 21:22:47 Done. Show quoted text On 2017/03/02 20:50:47, jbroman wrote: > nit: I'd just inline this into MojoDuplicateBufferHandleOptions. {readOnly: > true} seems like it's just as useful as {flags: {readOnly: true}}, but it's > shorter, simpler and faster. I see the fact that they're nested in Mojo as an > artifact of C vs JS API style. Done.
	6 boolean readOnly = false;

	7 };

OLD	NEW