Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: recipe_engine/package.py

Issue 2720853002: Fix GitBackend.checkout (Closed)
Patch Set: tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_engine/package.py
diff --git a/recipe_engine/package.py b/recipe_engine/package.py
index 97c2d2f7968d80ee9b64003753b552037c876a47..5914919e7395216ea82d146a9d0226dccb81bb89 100644
--- a/recipe_engine/package.py
+++ b/recipe_engine/package.py
@@ -220,7 +220,7 @@ class GitRepoSpec(RepoSpec):
repo spec refers to.
"""
raw_updates = self.raw_updates(
- context, (other_revision or self.backend.branch_spec(self.branch)))
+ context, (other_revision or 'refs/heads/' + self.branch))
updates = []
for rev in raw_updates:
# TODO(somebody): 'info' is not used.
@@ -262,7 +262,7 @@ class GitRepoSpec(RepoSpec):
"""Returns the more recent revision."""
self.checkout(context)
if context.allow_fetch:
- self.run_git(context, 'fetch')
+ self.run_git(context, 'fetch', self.repo, 'refs/heads/master')
Paweł Hajdan Jr. 2017/02/28 08:44:33 Similarly I'm worried about assumptions r1 and r2
args = [
'rev-list',
'%s...%s' % (r1, r2), # Note three dots (...) here.

Powered by Google App Engine
This is Rietveld 408576698