Issue 272083002: Linux NaCl BPF sandbox : restrict clone()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272083002: Linux NaCl BPF sandbox : restrict clone() (Closed)

Created:
6 years, 7 months ago by jln (very slow on Chromium)

Modified:
6 years, 7 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Linux NaCl BPF sandbox : restrict clone() Restrict clone() by defaulting to the baseline policy. This means that fork() will EPERM and only the flags used by pthread_create() will be allowed. BUG=367986 R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269167

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Mark Seaborn

LGTM It's a little surprising that we had an unrestricted clone() before. :-)

6 years, 7 months ago (2014-05-09 01:09:00 UTC) #2

jln (very slow on Chromium)

The CQ bit was checked by jln@chromium.org

6 years, 7 months ago (2014-05-09 02:10:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/272083002/1

6 years, 7 months ago (2014-05-09 02:18:34 UTC) #4

jln (very slow on Chromium)

6 years, 7 months ago (2014-05-09 06:53:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r269167 (presubmit successful).