Issue 27208002: remove SkDataSet, and just store a key/value in SkAnnotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27208002: remove SkDataSet, and just store a key/value in SkAnnotation (Closed)

Created:
7 years, 2 months ago by reed1

Modified:
7 years, 2 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

remove SkDataSet, and just store a key/value in SkAnnotation BUG= R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11759

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -335 lines)			Patch
M	gyp/public_headers.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkAnnotation.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
D	include/core/SkDataSet.h	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	src/core/SkAnnotation.cpp	View	2 chunks	+15 lines, -13 lines	0 comments	Download
M	src/core/SkData.cpp	View	1 chunk	+0 lines, -158 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/DataRefTest.cpp	View	3 chunks	+0 lines, -67 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

7 years, 2 months ago (2013-10-14 16:49:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r11759 (presubmit successful).