Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2720763003: Add support for field formal function typed formal parameters. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for field formal function typed formal parameters. Plus a couple of new tests. R=paulberry@google.com, ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/69063303ac21f1f2c7fc4c7521dd0685e683cb37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -32 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +31 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 4 chunks +25 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-02-27 21:34:28 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-02-27 21:59:20 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 69063303ac21f1f2c7fc4c7521dd0685e683cb37 (presubmit successful).
3 years, 9 months ago (2017-02-27 22:01:34 UTC) #4
ahe
3 years, 9 months ago (2017-02-28 05:06:45 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698