Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: third_party/WebKit/Source/web/WebDataSourceImpl.cpp

Issue 2720763002: PlzNavigate: preserve SourceLocation when navigating (Closed)
Patch Set: Addressed nate's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 DocumentLoader::detachFromFrame(); 154 DocumentLoader::detachFromFrame();
155 m_extraData.reset(); 155 m_extraData.reset();
156 } 156 }
157 157
158 void WebDataSourceImpl::setSubresourceFilter( 158 void WebDataSourceImpl::setSubresourceFilter(
159 WebDocumentSubresourceFilter* subresourceFilter) { 159 WebDocumentSubresourceFilter* subresourceFilter) {
160 DocumentLoader::setSubresourceFilter( 160 DocumentLoader::setSubresourceFilter(
161 SubresourceFilter::create(this, WTF::wrapUnique(subresourceFilter))); 161 SubresourceFilter::create(this, WTF::wrapUnique(subresourceFilter)));
162 } 162 }
163 163
164 void WebDataSourceImpl::setSourceLocation(
165 const WebSourceLocation& sourceLocation) {
166 std::unique_ptr<SourceLocation> location =
167 SourceLocation::create(sourceLocation.url, sourceLocation.lineNumber,
168 sourceLocation.columnNumber, nullptr);
169 DocumentLoader::setSourceLocation(std::move(location));
170 }
171
172 void WebDataSourceImpl::resetSourceLocation() {
173 DocumentLoader::setSourceLocation(nullptr);
174 }
175
164 DEFINE_TRACE(WebDataSourceImpl) { 176 DEFINE_TRACE(WebDataSourceImpl) {
165 DocumentLoader::trace(visitor); 177 DocumentLoader::trace(visitor);
166 } 178 }
167 179
168 } // namespace blink 180 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698