Issue 2720733004: Rewrite the extensions console to use gin::Wrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2720733004: Rewrite the extensions console to use gin::Wrappable. (Closed)

Created:
3 years, 9 months ago by jbroman

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rewrite the extensions console to use gin::Wrappable. BUG=

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -62 lines)			Patch
	M	extensions/renderer/console.h	View		1 chunk	+19 lines, -8 lines	0 comments	Download
	M	extensions/renderer/console.cc	View		4 chunks	+34 lines, -54 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jbroman

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-02-27 20:56:13 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720733004/1

3 years, 9 months ago (2017-02-27 20:56:47 UTC) #2

jbroman

Description was changed from ========== rewrite the extensions console to use gin::Wrappable BUG= ========== to ...

3 years, 9 months ago (2017-02-27 21:20:41 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-02-27 22:13:11 UTC) #4

commit-bot: I haz the power

3 years, 9 months ago (2017-02-27 22:13:12 UTC) #5

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages