Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2720723006: Address comments from Matthias on previous CL (Closed)

Created:
3 years, 9 months ago by Cutch
Modified:
3 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -69 lines) Patch
M runtime/vm/debugger.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +22 lines, -62 lines 0 comments Download
M runtime/vm/parser.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
3 years, 9 months ago (2017-02-28 21:47:19 UTC) #3
hausner
lgtm
3 years, 9 months ago (2017-02-28 21:52:00 UTC) #5
Cutch
3 years, 9 months ago (2017-02-28 22:02:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cb83f037e9e1cf079fabac76247a50b4a3cf29e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698