Extract MockBrowsingDataRemover to separate file to make it possible to use it

chrome/browser/chrome_content_browser_client_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <list>
 #include <map>
 #include <memory>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
-#include "chrome/browser/browsing_data/browsing_data_remover_impl.h"
+#include "chrome/browser/browsing_data/mock_browsing_data_remover.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/search_engines/template_url_service.h"
 #include "components/variations/entropy_provider.h"
 #include "components/variations/variations_associated_data.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/browsing_data_filter_builder.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
@@ skipping 303 matching lines @@
   ASSERT_TRUE(entry != NULL);
   EXPECT_EQ(url_rewritten, entry->GetURL());
   EXPECT_EQ(url_original, entry->GetVirtualURL());
 }
 
 }  // namespace content
 #endif  // !defined(OS_ANDROID)
 
 namespace {
 
-// A BrowsingDataRemover that only records calls.
-// TODO(msramek): Once BrowsingDataRemoverImpl moves to content/ (non-public),
-// it will not be possible to inherit from it here. However, at that time
-// this functionality will become redundant, as it will no longer be necessary
-// to call to chrome/ to perform deletion. Remove it then.
-class MockBrowsingDataRemover : public BrowsingDataRemoverImpl {
- public:
-  explicit MockBrowsingDataRemover(content::BrowserContext* context)
-      : BrowsingDataRemoverImpl(context) {}
-
-  ~MockBrowsingDataRemover() override {
-    DCHECK(!expected_calls_.size())
-        << "Expectations were set but not verified.";
-  }
-
-  void RemoveInternal(const base::Time& delete_begin,
-                      const base::Time& delete_end,
-                      int remove_mask,
-                      int origin_type_mask,
-                      std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
-                      BrowsingDataRemover::Observer* observer) override {
-    actual_calls_.emplace_back(delete_begin, delete_end, remove_mask,
-                               origin_type_mask, std::move(filter_builder),
-                               true /* should_compare_filter */);
-
-    // |observer| is not recorded in |actual_calls_| to be compared with
-    // expectations, because it's created internally in ClearSiteData() and
-    // it's unknown to this. However, it is tested implicitly, because we use
-    // it for the completion callback, so an incorrect |observer| will fail
-    // the test by waiting for the callback forever.
-    DCHECK(observer);
-    observer->OnBrowsingDataRemoverDone();
-  }
-
-  void ExpectCall(
-      const base::Time& delete_begin,
-      const base::Time& delete_end,
-      int remove_mask,
-      int origin_type_mask,
-      std::unique_ptr<BrowsingDataFilterBuilder> filter_builder) {
-    expected_calls_.emplace_back(delete_begin, delete_end, remove_mask,
-                                 origin_type_mask, std::move(filter_builder),
-                                 true /* should_compare_filter */);
-  }
-
-  void ExpectCallDontCareAboutFilterBuilder(const base::Time& delete_begin,
-                                            const base::Time& delete_end,
-                                            int remove_mask,
-                                            int origin_type_mask) {
-    expected_calls_.emplace_back(delete_begin, delete_end, remove_mask,
-                                 origin_type_mask,
-                                 std::unique_ptr<BrowsingDataFilterBuilder>(),
-                                 false /* should_compare_filter */);
-  }
-
-  void VerifyAndClearExpectations() {
-    EXPECT_EQ(expected_calls_, actual_calls_);
-    expected_calls_.clear();
-    actual_calls_.clear();
-  }
-
- private:
-  class CallParameters {
-   public:
-    CallParameters(const base::Time& delete_begin,
-                   const base::Time& delete_end,
-                   int remove_mask,
-                   int origin_type_mask,
-                   std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
-                   bool should_compare_filter)
-        : delete_begin_(delete_begin),
-          delete_end_(delete_end),
-          remove_mask_(remove_mask),
-          origin_type_mask_(origin_type_mask),
-          filter_builder_(std::move(filter_builder)),
-          should_compare_filter_(should_compare_filter) {}
-    ~CallParameters() {}
-
-    bool operator==(const CallParameters& other) const {
-      const CallParameters& a = *this;
-      const CallParameters& b = other;
-
-      if (a.delete_begin_ != b.delete_begin_ ||
-          a.delete_end_ != b.delete_end_ ||
-          a.remove_mask_ != b.remove_mask_ ||
-          a.origin_type_mask_ != b.origin_type_mask_) {
-        return false;
-      }
-
-      if (!a.should_compare_filter_ || !b.should_compare_filter_)
-        return true;
-      return *a.filter_builder_ == *b.filter_builder_;
-    }
-
-   private:
-    base::Time delete_begin_;
-    base::Time delete_end_;
-    int remove_mask_;
-    int origin_type_mask_;
-    std::unique_ptr<BrowsingDataFilterBuilder> filter_builder_;
-    bool should_compare_filter_;
-  };
-
-  std::list<CallParameters> actual_calls_;
-  std::list<CallParameters> expected_calls_;
-};
-
 // Tests for ChromeContentBrowserClient::ClearSiteData().
 class ChromeContentBrowserClientClearSiteDataTest : public testing::Test {
  public:
   void SetUp() override {
     BrowsingDataRemoverFactory::GetInstance()->SetTestingFactoryAndUse(
         &profile_, &ChromeContentBrowserClientClearSiteDataTest::GetRemover);
   }
 
   content::BrowserContext* profile() { return &profile_; }
 
@@ skipping 218 matching lines @@
   client.ClearSiteData(
       profile(), origin, true /* cookies */, false /* storage */,
       true /* cache */,
       base::Bind(
           &ChromeContentBrowserClientClearSiteDataTest::SetClearingFinished,
           base::Unretained(this), true));
   EXPECT_TRUE(IsClearingFinished());
 }
 
 }  // namespace