Issue 2720693003: VM: [Kernel] Pass correct parameters to fasta's TranslateUri.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2720693003: VM: [Kernel] Pass correct parameters to fasta's TranslateUri.parse. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)

Modified:
3 years, 9 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: [Kernel] Pass correct parameters to fasta's TranslateUri.parse. Signature is TranslateUri.parse(Uri sdk, [Uri uri]) so path to the packages file should be passed as a second argument and not the first one. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b7a956e0c0162c893b3491b7171d1d2a80f1744

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	utils/kernel-service/kernel-service.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

3 years, 9 months ago (2017-02-27 13:01:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3b7a956e0c0162c893b3491b7171d1d2a80f1744 (presubmit successful).