Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Issue 2720683003: Clear pointers to PendingScript when dispose()d in pendingScriptFinished() (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
index 88afa39d916a2a36115136ef176f2b1000c90df6..596bb2d50b30d3c0c0e8d8874bc392daa6ac5dec 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
@@ -363,6 +363,13 @@ void HTMLParserScriptRunner::pendingScriptFinished(
// The parser is unprepared to be told, and doesn't need to be.
if (isExecutingScript() && pendingScript->resource()->wasCanceled()) {
pendingScript->dispose();
+
+ // TODO(hiroshige): According to the comment above,
+ // this block is intended to process |m_parserBlockingScript|.
+ // If this CHECK() should fail, implement the case where
+ // |m_parserBlockingScript == m_scriptsToExecuteAfterParsing.first()|.
kouhei (in TOK) 2017/02/28 00:41:48 I'm not sure if we should do that per se. I'd rath
hiroshige 2017/02/28 00:48:55 |m_parserBlockingScript| and |m_scriptsToExecuteAf
+ CHECK_EQ(pendingScript, parserBlockingScript());
+ m_parserBlockingScript = nullptr;
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698