Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2720663002: Revert of Implement complete lifecycle transition for IdleSpellCheckCallback (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index e75a8b37c7199751dbba63c16de70a353b71d592..bbde6b096c1b1a4d66f6080f7e25d58cad78f4a0 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -923,10 +923,8 @@
void SpellChecker::respondToChangedSelection(
const Position& oldSelectionStart,
FrameSelection::SetSelectionOptions options) {
- if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled()) {
- m_idleSpellCheckCallback->setNeedsInvocation();
- return;
- }
+ if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
+ return;
TRACE_EVENT0("blink", "SpellChecker::respondToChangedSelection");
if (!isSpellCheckingEnabledFor(oldSelectionStart))
@@ -968,12 +966,6 @@
// FIXME(http://crbug.com/382809): if oldSelection is on a textarea
// element, we cause synchronous layout.
spellCheckOldSelection(oldSelectionStart, newAdjacentWords);
-}
-
-void SpellChecker::respondToChangedContents(const VisibleSelection& selection) {
- updateMarkersForWordsAffectedByEditing(true);
- if (RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
- m_idleSpellCheckCallback->setNeedsInvocation();
}
void SpellChecker::removeSpellingMarkers() {
@@ -1107,10 +1099,6 @@
// checker.
void SpellChecker::cancelCheck() {
m_spellCheckRequester->cancelCheck();
-}
-
-void SpellChecker::documentAttached(Document* document) {
- m_idleSpellCheckCallback->documentAttached(document);
}
DEFINE_TRACE(SpellChecker) {
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698