Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp

Issue 2720663002: Revert of Implement complete lifecycle transition for IdleSpellCheckCallback (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp
deleted file mode 100644
index a9976c05128828309906b211432820774b4e2cbd..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallbackTest.cpp
+++ /dev/null
@@ -1,136 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "core/editing/spellcheck/IdleSpellCheckCallback.h"
-
-#include "core/editing/spellcheck/SpellCheckTestBase.h"
-#include "core/editing/spellcheck/SpellChecker.h"
-#include "core/frame/LocalFrame.h"
-#include "platform/RuntimeEnabledFeatures.h"
-
-namespace blink {
-
-using State = IdleSpellCheckCallback::State;
-
-class IdleSpellCheckCallbackTest : public SpellCheckTestBase {
- protected:
- IdleSpellCheckCallback& idleChecker() {
- return frame().spellChecker().idleSpellCheckCallback();
- }
-
- void SetUp() override {
- SpellCheckTestBase::SetUp();
- if (!RuntimeEnabledFeatures::idleTimeSpellCheckingEnabled())
- idleChecker().documentAttached(frame().document());
- }
-
- void transitTo(State state) {
- switch (state) {
- case State::kInactive:
- idleChecker().deactivate();
- break;
- case State::kHotModeRequested:
- idleChecker().setNeedsInvocation();
- break;
- case State::kColdModeTimerStarted:
- break;
- case State::kColdModeRequested:
- idleChecker().skipColdModeTimerForTesting();
- break;
- case State::kInHotModeInvocation:
- case State::kInColdModeInvocation:
- NOTREACHED();
- }
- }
-};
-
-// Test cases for lifecycle state transitions.
-
-TEST_F(IdleSpellCheckCallbackTest, Initialization) {
- EXPECT_EQ(State::kColdModeTimerStarted, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, RequestWhenInactive) {
- transitTo(State::kInactive);
- idleChecker().setNeedsInvocation();
- EXPECT_EQ(State::kHotModeRequested, idleChecker().state());
- EXPECT_NE(-1, idleChecker().idleCallbackHandle());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, RequestWhenHotModeRequested) {
- transitTo(State::kHotModeRequested);
- int handle = idleChecker().idleCallbackHandle();
- idleChecker().setNeedsInvocation();
- EXPECT_EQ(State::kHotModeRequested, idleChecker().state());
- EXPECT_EQ(handle, idleChecker().idleCallbackHandle());
- EXPECT_NE(-1, idleChecker().idleCallbackHandle());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, RequestWhenColdModeTimerStarted) {
- transitTo(State::kColdModeTimerStarted);
- idleChecker().setNeedsInvocation();
- EXPECT_EQ(State::kHotModeRequested, idleChecker().state());
- EXPECT_NE(-1, idleChecker().idleCallbackHandle());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, RequestWhenColdModeRequested) {
- transitTo(State::kColdModeRequested);
- int handle = idleChecker().idleCallbackHandle();
- idleChecker().setNeedsInvocation();
- EXPECT_EQ(State::kHotModeRequested, idleChecker().state());
- EXPECT_EQ(handle, idleChecker().idleCallbackHandle());
- EXPECT_NE(-1, idleChecker().idleCallbackHandle());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, HotModeTransitToColdMode) {
- transitTo(State::kHotModeRequested);
- idleChecker().forceInvocationForTesting();
- EXPECT_EQ(State::kColdModeTimerStarted, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, ColdModeTimerStartedToRequested) {
- transitTo(State::kColdModeTimerStarted);
- idleChecker().skipColdModeTimerForTesting();
- EXPECT_EQ(State::kColdModeRequested, idleChecker().state());
- EXPECT_NE(-1, idleChecker().idleCallbackHandle());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, ColdModeStayAtColdMode) {
- transitTo(State::kColdModeRequested);
- idleChecker().setNeedsMoreColdModeInvocationForTesting();
- idleChecker().forceInvocationForTesting();
- EXPECT_EQ(State::kColdModeTimerStarted, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, ColdModeToInactive) {
- transitTo(State::kColdModeRequested);
- idleChecker().forceInvocationForTesting();
- EXPECT_EQ(State::kInactive, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, DetachWhenInactive) {
- transitTo(State::kInactive);
- document().shutdown();
- EXPECT_EQ(State::kInactive, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, DetachWhenHotModeRequested) {
- transitTo(State::kHotModeRequested);
- document().shutdown();
- EXPECT_EQ(State::kInactive, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, DetachWhenColdModeTimerStarted) {
- transitTo(State::kColdModeTimerStarted);
- document().shutdown();
- EXPECT_EQ(State::kInactive, idleChecker().state());
-}
-
-TEST_F(IdleSpellCheckCallbackTest, DetachWhenColdModeRequested) {
- transitTo(State::kColdModeRequested);
- document().shutdown();
- EXPECT_EQ(State::kInactive, idleChecker().state());
-}
-
-} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698