Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2720653002: CSS Motion Path: Implement animation for the offset-path property

Created:
3 years, 9 months ago by Eric Willigers
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Motion Path: Implement animation for the offset-path property We interpolate between paths when they have the same number and type of path segments. BUG=696395

Patch Set 1 #

Total comments: 2

Patch Set 2 : move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -57 lines) Patch
A + third_party/WebKit/LayoutTests/animations/interpolation/offset-path-interpolation.html View 29 chunks +32 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/svg-d-interpolation.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp View 1 4 chunks +11 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/core/animation/PathPropertyFunctions.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp View 1 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
Eric Willigers
Not for landing before branch point.
3 years, 9 months ago (2017-02-27 04:11:49 UTC) #2
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/2720653002/diff/1/third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp File third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp (right): https://codereview.chromium.org/2720653002/diff/1/third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp#newcode26 third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp:26: PassRefPtr<blink::StylePath> path) { PassRefPtr is deprecated, use std::move(RefPtr) ...
3 years, 9 months ago (2017-02-27 04:15:17 UTC) #5
Eric Willigers
3 years, 9 months ago (2017-02-27 04:30:30 UTC) #6 
https://codereview.chromium.org/2720653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp (right):

https://codereview.chromium.org/2720653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/PathPropertyFunctions.cpp:26:
PassRefPtr<blink::StylePath> path) {
On 2017/02/27 04:15:17, alancutter wrote:
> PassRefPtr is deprecated, use std::move(RefPtr) instead.

Done.

Powered by Google App Engine
This is Rietveld 408576698