Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: components/safe_browsing/password_protection/BUILD.gn

Issue 2720643003: Call CSD whitelist checking on UI thread and record UMA (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/BUILD.gn
diff --git a/components/safe_browsing/password_protection/BUILD.gn b/components/safe_browsing/password_protection/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..c6016331140abb47a8c66eb70d797acf65ae312e
--- /dev/null
+++ b/components/safe_browsing/password_protection/BUILD.gn
@@ -0,0 +1,35 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+source_set("pp_service") {
blundell 2017/03/02 15:54:02 nit: you should just call these targets password_p
Jialiu Lin 2017/03/02 19:02:50 Done.
+ sources = [
+ "password_protection_service.cc",
+ "password_protection_service.h",
+ ]
+
+ deps = [
+ "//base:base",
+ "//components/history/core/browser:browser",
+ "//components/safe_browsing_db:database_manager",
+ "//content/public/browser:browser",
+ "//third_party/protobuf:protobuf_lite",
+ ]
+}
+
+source_set("pp_service_unittest") {
+ testonly = true
+ sources = [
+ "password_protection_service_unittest.cc",
+ ]
+ deps = [
+ ":pp_service",
+ "//base",
+ "//base/test:test_support",
+ "//components/safe_browsing_db:test_database_manager",
+ "//content/test:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/protobuf:protobuf_lite",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698