Call CSD whitelist checking on UI thread and record UMA

chrome/browser/safe_browsing/safe_browsing_service.cc

Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 2ecf2d09f5dcbd4740b732d6729c42d351ee0ecf..49cbabd3d88986f71c4b5516aee28fb3b3c70c2a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -38,6 +38,7 @@
 #include "components/prefs/pref_service.h"
 #include "components/safe_browsing/common/safebrowsing_constants.h"
 #include "components/safe_browsing/common/safebrowsing_switches.h"
+#include "components/safe_browsing/password_protection/password_protection_service.h"
 #include "components/safe_browsing_db/database_manager.h"
 #include "components/safe_browsing_db/v4_feature_list.h"
 #include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"
@@ -328,6 +329,11 @@ void SafeBrowsingService::Initialize() {
     navigation_observer_manager_ = new SafeBrowsingNavigationObserverManager();
   }
 
+  // TODO(jialiul): When PasswordProtectionService does more than reporting UMA,
+  // we need to add finch trial to gate its functionality.
+  password_protection_service_ =
+      new PasswordProtectionService(database_manager());

[Nathan Parker, 2017/03/01 22:59:22]

nit: I think these and others around here should be std::make_unique<..>(..).
'tis the new style, so we dont' get used to using "new"

[vakh (use Gerrit instead), 2017/03/01 23:25:19]

+1
I see what you did there.

[Jialiu Lin, 2017/03/02 00:53:06]

Done.

[Jialiu Lin, 2017/03/02 00:53:06]

Done. Change it from scoped_refptr to unique_ptr instead.

+
   services_delegate_->Initialize(v4_enabled_);
   services_delegate_->InitializeCsdService(url_request_context_getter_.get());
 
@@ -447,6 +453,11 @@ SafeBrowsingService::v4_local_database_manager() const {
   return services_delegate_->v4_local_database_manager();
 }
 
+scoped_refptr<PasswordProtectionService>
+SafeBrowsingService::password_protection_service() {
+  return password_protection_service_;

[vakh (use Gerrit instead), 2017/03/01 23:25:19]

This can go in the header file.
https://google.github.io/styleguide/cppguide.html#Inline_Functions

[Jialiu Lin, 2017/03/02 00:53:06]

Acknowledged. Since all the other getters are defined in .cc file. It looks more
consistent to keep it here.

+}
+
 std::unique_ptr<TrackedPreferenceValidationDelegate>
 SafeBrowsingService::CreatePreferenceValidationDelegate(
     Profile* profile) const {