Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Side by Side Diff: components/safe_browsing/password_protection/password_protection_service.h

Issue 2720643003: Call CSD whitelist checking on UI thread and record UMA (Closed)
Patch Set: Add TODO Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_SAFE_BROWSING_PASSWORD_PROTECTION_PASSWORD_PROTECTION_SERVICE _H_
6 #define COMPONENTS_SAFE_BROWSING_PASSWORD_PROTECTION_PASSWORD_PROTECTION_SERVICE _H_
7
8 #include <string>
9
10 #include "base/macros.h"
11 #include "base/memory/ref_counted.h"
12
13 class GURL;
14
15 namespace safe_browsing {
16
17 class SafeBrowsingDatabaseManager;
18
19 class PasswordProtectionService
20 : public base::RefCountedThreadSafe<PasswordProtectionService> {
21 public:
22 PasswordProtectionService(
23 const scoped_refptr<SafeBrowsingDatabaseManager>& database_manager);
24
25 // Called on UI thread.
26 void RecordPasswordReuse(const GURL& main_frame_url);
Nathan Parker 2017/03/01 22:59:22 Other args we may want, eventually: * origins of t
vakh (use Gerrit instead) 2017/03/01 23:25:19 Same for this method... please add a comment expla
Jialiu Lin 2017/03/02 00:53:06 Done.
Jialiu Lin 2017/03/02 00:53:06 ack. It seems password_reuse_detection_manager its
Nathan Parker 2017/03/02 01:02:42 nah, never mind -- we can add it later when we wan
27
28 protected:
29 virtual ~PasswordProtectionService();
30 // Called on UI thread.
vakh (use Gerrit instead) 2017/03/01 23:25:20 This is a good place to describe when this functio
Jialiu Lin 2017/03/02 00:53:06 Done.
31 void OnMatchCsdWhiteListResult(bool match_whitelist);
32
33 private:
34 friend class base::RefCountedThreadSafe<PasswordProtectionService>;
35
36 scoped_refptr<SafeBrowsingDatabaseManager> database_manager_;
37
38 DISALLOW_COPY_AND_ASSIGN(PasswordProtectionService);
39 };
40
41 } // namespace safe_browsing
42
43 #endif // COMPONENTS_SAFE_BROWSING_PASSWORD_PROTECTION_PASSWORD_PROTECTION_SERV ICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698