components/safe_browsing/password_protection/DEPS - Issue 2720643003: Call CSD whitelist checking on UI thread and record UMA

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/password_protection/DEPS

Issue 2720643003: Call CSD whitelist checking on UI thread and record UMA (Closed)

Patch Set: Add TODO Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "-content",
	vakh (use Gerrit instead) 2017/03/01 23:25:19 What does '-' signify? What does '-' signify? vakh (use Gerrit instead) 2017/03/02 01:01:01 ^ Show quoted text On 2017/03/01 23:25:19, vakh (Varun Khaneja) wrote: > What does '-' signify? ^ Jialiu Lin 2017/03/02 01:33:14 Ah, sorry. Missed this one. This is to tighten the Show quoted text On 2017/03/02 01:01:01, vakh (Varun Khaneja) wrote: > On 2017/03/01 23:25:19, vakh (Varun Khaneja) wrote: > > What does '-' signify? > > ^ Ah, sorry. Missed this one. This is to tighten the DEPS introduced by parent folder. Basically it means removing deps to all content/, and adding only content/public/browser and content/public/test.
	3 "+components/safe_browsing_db",

	4 "+content/public/browser",

	5 "+content/public/test",

	6 ]

	7

OLD	NEW