Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3822)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java

Issue 2720613002: Downloads: Added transient flag to download item and download database (Closed)
Patch Set: Fixed migration unit test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
index 0e2be2ddc89effe91dba949a43b1784a1fad958e..093674292f38f1d7b9eaf929fd8d7ae79aeeadfa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
@@ -33,6 +33,7 @@ public final class DownloadInfo {
private final boolean mIsOfflinePage;
private final int mState;
private final long mLastAccessTime;
+ private final boolean mIsVisible;
private DownloadInfo(Builder builder) {
mUrl = builder.mUrl;
@@ -57,6 +58,7 @@ public final class DownloadInfo {
mIsOfflinePage = builder.mIsOfflinePage;
mState = builder.mState;
mLastAccessTime = builder.mLastAccessTime;
+ mIsVisible = builder.mIsVisible;
}
public String getUrl() {
@@ -153,6 +155,10 @@ public final class DownloadInfo {
return mLastAccessTime;
}
+ public boolean isVisible() {
David Trainor- moved to gerrit 2017/03/06 18:28:39 Do we want to make this have an impact on the UI?
shaktisahu 2017/03/08 06:51:30 Removed from Java layer.
+ return mIsVisible;
+ }
+
/**
* Helper class for building the DownloadInfo object.
*/
@@ -179,6 +185,7 @@ public final class DownloadInfo {
private boolean mIsOfflinePage;
private int mState = DownloadState.IN_PROGRESS;
private long mLastAccessTime;
+ private boolean mIsVisible;
public Builder setUrl(String url) {
mUrl = url;
@@ -291,6 +298,11 @@ public final class DownloadInfo {
return this;
}
+ public Builder setIsVisible(boolean isVisible) {
+ mIsVisible = isVisible;
+ return this;
+ }
+
public DownloadInfo build() {
return new DownloadInfo(this);
}
@@ -323,7 +335,8 @@ public final class DownloadInfo {
.setIsOffTheRecord(downloadInfo.isOffTheRecord())
.setIsOfflinePage(downloadInfo.isOfflinePage())
.setState(downloadInfo.state())
- .setLastAccessTime(downloadInfo.getLastAccessTime());
+ .setLastAccessTime(downloadInfo.getLastAccessTime())
+ .setIsVisible(downloadInfo.isVisible());
return builder;
}
}
@@ -333,7 +346,7 @@ public final class DownloadInfo {
String filePath, String url, String mimeType, long bytesReceived, boolean isIncognito,
int state, int percentCompleted, boolean isPaused, boolean hasUserGesture,
boolean isResumable, String originalUrl, String referrerUrl, long timeRemainingInMs,
- long lastAccessTime) {
+ long lastAccessTime, boolean isVisible) {
String remappedMimeType = ChromeDownloadDelegate.remapGenericMimeType(
mimeType, url, fileName);
return new DownloadInfo.Builder()
@@ -353,6 +366,7 @@ public final class DownloadInfo {
.setState(state)
.setTimeRemainingInMillis(timeRemainingInMs)
.setLastAccessTime(lastAccessTime)
+ .setIsVisible(isVisible)
.setUrl(url)
.build();
}

Powered by Google App Engine
This is Rietveld 408576698