Downloads: Added transient flag to download item and download database

chrome/browser/android/download/download_manager_service.cc

Index: chrome/browser/android/download/download_manager_service.cc
diff --git a/chrome/browser/android/download/download_manager_service.cc b/chrome/browser/android/download/download_manager_service.cc
index 8b0921a8fc6d971139b7e0cc4ef66888441b9ba4..3d4119d1edcdda80cb660397c7530e4b5717a411 100644
--- a/chrome/browser/android/download/download_manager_service.cc
+++ b/chrome/browser/android/download/download_manager_service.cc
@@ -41,7 +41,7 @@ int kDefaultAutoResumptionLimit = 5;
 const char kAutoResumptionLimitVariation[] = "AutoResumptionLimit";
 
 bool ShouldShowDownloadItem(content::DownloadItem* item) {
-  return !item->IsTemporary();
+  return !item->IsTemporary() && item->IsTransient();
 }
 
 void UpdateNotifier(DownloadManagerService* service,
@@ -57,6 +57,7 @@ void UpdateNotifier(DownloadManagerService* service,
 
 ScopedJavaLocalRef<jobject> CreateJavaDownloadItem(
     JNIEnv* env, content::DownloadItem* item) {
+  DCHECK(item->IsTransient());

[brettw, 2017/03/29 22:54:13]

I don't follow this check, if we're creating java download items I would expect
them to be not transient. If this code is correct, can you add a comment
explaining?

[shaktisahu, 2017/03/29 23:46:47]

Corrected now. 

   return Java_DownloadItem_createDownloadItem(
       env, DownloadManagerService::CreateJavaDownloadInfo(env, item),
       item->GetStartTime().ToJavaTime(), item->GetFileExternallyRemoved());
@@ -301,6 +302,8 @@ void DownloadManagerService::OnHistoryQueryComplete() {
 
 void DownloadManagerService::OnDownloadCreated(
     content::DownloadManager* manager, content::DownloadItem* item) {
+  if (!item->IsTransient())
+    return;
 
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_item = CreateJavaDownloadItem(env, item);
@@ -313,7 +316,7 @@ void DownloadManagerService::OnDownloadUpdated(
   if (java_ref_.is_null())
     return;
 
-  if (item->IsTemporary())
+  if (item->IsTemporary() || !item->IsTransient())
     return;
 
   JNIEnv* env = base::android::AttachCurrentThread();
@@ -324,7 +327,7 @@ void DownloadManagerService::OnDownloadUpdated(
 
 void DownloadManagerService::OnDownloadRemoved(
     content::DownloadManager* manager, content::DownloadItem* item) {
-  if (java_ref_.is_null())
+  if (java_ref_.is_null() || !item->IsTransient())
     return;
 
   JNIEnv* env = base::android::AttachCurrentThread();