Downloads: Added transient flag to download item and download database

chrome/browser/download/download_history.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // DownloadHistory manages persisting DownloadItems to the history service by
 // observing a single DownloadManager and all its DownloadItems using an
 // AllDownloadItemNotifier.
 //
 // DownloadHistory decides whether and when to add items to, remove items from,
 // and update items in the database. DownloadHistory uses DownloadHistoryData to
@@ skipping 123 matching lines @@
       item->GetTabReferrerUrl(),
       std::string(),  // HTTP method (not available yet)
       item->GetMimeType(), item->GetOriginalMimeType(), item->GetStartTime(),
       item->GetEndTime(), item->GetETag(), item->GetLastModifiedTime(),
       item->GetReceivedBytes(), item->GetTotalBytes(),
       history::ToHistoryDownloadState(item->GetState()),
       history::ToHistoryDownloadDangerType(item->GetDangerType()),
       history::ToHistoryDownloadInterruptReason(item->GetLastReason()),
       std::string(),  // Hash value (not available yet)
       history::ToHistoryDownloadId(item->GetId()), item->GetGuid(),
-      item->GetOpened(), item->GetLastAccessTime(), by_ext_id, by_ext_name,
-      history::GetHistoryDownloadSliceInfos(*item));
+      item->GetOpened(), item->GetLastAccessTime(), item->IsTransient(),
+      by_ext_id, by_ext_name, history::GetHistoryDownloadSliceInfos(*item));
 }
 
 enum class ShouldUpdateHistoryResult {
   NO_UPDATE,
   UPDATE,
   UPDATE_IMMEDIATELY,
 };
 
 ShouldUpdateHistoryResult ShouldUpdateHistory(
     const history::DownloadRow* previous,
@@ skipping 16 matching lines @@
       (previous->received_bytes != current.received_bytes) ||
       (previous->total_bytes != current.total_bytes) ||
       (previous->etag != current.etag) ||
       (previous->last_modified != current.last_modified) ||
       (previous->state != current.state) ||
       (previous->danger_type != current.danger_type) ||
       (previous->interrupt_reason != current.interrupt_reason) ||
       (previous->hash != current.hash) ||
       (previous->opened != current.opened) ||
       (previous->last_access_time != current.last_access_time) ||
+      (previous->transient != current.transient) ||
       (previous->by_ext_id != current.by_ext_id) ||
       (previous->by_ext_name != current.by_ext_name) ||
       (previous->download_slice_info != current.download_slice_info)) {
     return ShouldUpdateHistoryResult::UPDATE;
   }
 
   return ShouldUpdateHistoryResult::NO_UPDATE;
 }
 
 typedef std::vector<history::DownloadRow> InfoVector;
@@ skipping 100 matching lines @@
         it->guid, loading_id_, it->current_path, it->target_path, it->url_chain,
         it->referrer_url, it->site_url, it->tab_url, it->tab_referrer_url,
         it->mime_type, it->original_mime_type, it->start_time, it->end_time,
         it->etag, it->last_modified, it->received_bytes, it->total_bytes,
         std::string(),  // TODO(asanka): Need to persist and restore hash of
                         // partial file for an interrupted download. No need to
                         // store hash for a completed file.
         history::ToContentDownloadState(it->state),
         history::ToContentDownloadDangerType(it->danger_type),
         history::ToContentDownloadInterruptReason(it->interrupt_reason),
-        it->opened, it->last_access_time,
+        it->opened, it->last_access_time, it->transient,
         history::ToContentReceivedSlices(it->download_slice_info));
 #if BUILDFLAG(ENABLE_EXTENSIONS)
     if (!it->by_ext_id.empty() && !it->by_ext_name.empty()) {
       new extensions::DownloadedByExtension(
           item, it->by_ext_id, it->by_ext_name);
       item->UpdateObservers();
     }
 #endif
     DCHECK_EQ(DownloadHistoryData::PERSISTED,
               DownloadHistoryData::Get(item)->state());
@@ skipping 181 matching lines @@
 }
 
 void DownloadHistory::RemoveDownloadsBatch() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   IdSet remove_ids;
   removing_ids_.swap(remove_ids);
   history_->RemoveDownloads(remove_ids);
   for (Observer& observer : observers_)
     observer.OnDownloadsRemoved(remove_ids);
 }