Downloads: Added transient flag to download item and download database

content/browser/download/download_item_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // File method ordering: Methods in this file are in the same order as
 // in download_item_impl.h, with the following exception: The public
 // interface Start is placed in chronological order with the other
 // (private) routines that together define a DownloadItem's state
 // transitions as the download progresses.  See "Download progression
 // cascade" later in this file.
@@ skipping 128 matching lines @@
     const std::string& etag,
     const std::string& last_modified,
     int64_t received_bytes,
     int64_t total_bytes,
     const std::string& hash,
     DownloadItem::DownloadState state,
     DownloadDangerType danger_type,
     DownloadInterruptReason interrupt_reason,
     bool opened,
     const base::Time& last_access_time,
+    bool visible,
     const std::vector<DownloadItem::ReceivedSlice>& received_slices,
     const net::NetLogWithSource& net_log)
     : guid_(base::ToUpperASCII(guid)),
       download_id_(download_id),
       target_path_(target_path),
       url_chain_(url_chain),
       referrer_url_(referrer_url),
       site_url_(site_url),
       tab_url_(tab_url),
       tab_referrer_url_(tab_refererr_url),
       mime_type_(mime_type),
       original_mime_type_(original_mime_type),
       total_bytes_(total_bytes),
       last_reason_(interrupt_reason),
       start_tick_(base::TimeTicks()),
       state_(ExternalToInternalState(state)),
       danger_type_(danger_type),
       start_time_(start_time),
       end_time_(end_time),
       delegate_(delegate),
       opened_(opened),
       last_access_time_(last_access_time),
+      visible_(visible),
       current_path_(current_path),
       received_bytes_(received_bytes),
       all_data_saved_(state == COMPLETE),
       hash_(hash),
       last_modified_time_(last_modified),
       etag_(etag),
       received_slices_(received_slices),
       net_log_(net_log),
       weak_ptr_factory_(this) {
   delegate_->Attach();
@@ skipping 590 matching lines @@
 }
 
 bool DownloadItemImpl::GetOpened() const {
   return opened_;
 }
 
 base::Time DownloadItemImpl::GetLastAccessTime() const {
   return last_access_time_;
 }
 
+bool DownloadItemImpl::IsVisible() const {
+  return visible_;

[vitaliii, 2017/03/07 07:58:56]

Could you add any comment on when IsVisible is false (or at least explain it
here)?

If I encounter this code, I would be confused. It feels like I should not show
items with IsVisible == false in UI, but I am not sure.

[shaktisahu, 2017/03/08 06:51:30]

Comments are usually found above the method declaration in the interface which
in this case is download_item.h.
Yes, the intent here is that if isVisible=false, we shouldn't show this on the
UI.

[dgn, 2017/03/08 13:12:04]

All right, but there is no context to why this is being added. What would make a
download item invisible? How does it affect the behaviour of the item besides
whether it's shown in the UI? Can you please link a bug in the description?

+}
+
 BrowserContext* DownloadItemImpl::GetBrowserContext() const {
   return delegate_->GetBrowserContext();
 }
 
 WebContents* DownloadItemImpl::GetWebContents() const {
   // TODO(rdsmith): Remove null check after removing GetWebContents() from
   // paths that might be used by DownloadItems created from history import.
   // Currently such items have null request_handle_s, where other items
   // (regular and SavePackage downloads) have actual objects off the pointer.
   if (request_handle_)
@@ skipping 1349 matching lines @@
     case RESUME_MODE_USER_CONTINUE:
       return "USER_CONTINUE";
     case RESUME_MODE_USER_RESTART:
       return "USER_RESTART";
   }
   NOTREACHED() << "Unknown resume mode " << mode;
   return "unknown";
 }
 
 }  // namespace content