Downloads: Added transient flag to download item and download database

chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.download;
 
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.content_public.browser.DownloadState;
 
 /**
@@ skipping 15 matching lines @@
     private final String mContentDisposition;
     private final boolean mIsGETRequest;
     private final int mPercentCompleted;
     private final long mTimeRemainingInMillis;
     private final boolean mIsResumable;
     private final boolean mIsPaused;
     private final boolean mIsOffTheRecord;
     private final boolean mIsOfflinePage;
     private final int mState;
     private final long mLastAccessTime;
+    private final boolean mIsVisible;
 
     private DownloadInfo(Builder builder) {
         mUrl = builder.mUrl;
         mUserAgent = builder.mUserAgent;
         mMimeType = builder.mMimeType;
         mCookie = builder.mCookie;
         mFileName = builder.mFileName;
         mDescription = builder.mDescription;
         mFilePath = builder.mFilePath;
         mReferrer = builder.mReferrer;
         mOriginalUrl = builder.mOriginalUrl;
         mBytesReceived = builder.mBytesReceived;
         mDownloadGuid = builder.mDownloadGuid;
         mHasUserGesture = builder.mHasUserGesture;
         mIsGETRequest = builder.mIsGETRequest;
         mContentDisposition = builder.mContentDisposition;
         mPercentCompleted = builder.mPercentCompleted;
         mTimeRemainingInMillis = builder.mTimeRemainingInMillis;
         mIsResumable = builder.mIsResumable;
         mIsPaused = builder.mIsPaused;
         mIsOffTheRecord = builder.mIsOffTheRecord;
         mIsOfflinePage = builder.mIsOfflinePage;
         mState = builder.mState;
         mLastAccessTime = builder.mLastAccessTime;
+        mIsVisible = builder.mIsVisible;
     }
 
     public String getUrl() {
         return mUrl;
     }
 
     public String getUserAgent() {
         return mUserAgent;
     }
 
@@ skipping 76 matching lines @@
     }
 
     public int state() {
         return mState;
     }
 
     public long getLastAccessTime() {
         return mLastAccessTime;
     }
 
+    public boolean isVisible() {

[David Trainor- moved to gerrit, 2017/03/06 18:28:39]

Do we want to make this have an impact on the UI?  Maybe add a TODO and file a
follow up bug?

[shaktisahu, 2017/03/08 06:51:30]

Removed from Java layer.

+        return mIsVisible;
+    }
+
     /**
      * Helper class for building the DownloadInfo object.
      */
     public static class Builder {
         private String mUrl;
         private String mUserAgent;
         private String mMimeType;
         private String mCookie;
         private String mFileName;
         private String mDescription;
         private String mFilePath;
         private String mReferrer;
         private String mOriginalUrl;
         private long mBytesReceived;
         private boolean mIsGETRequest;
         private String mDownloadGuid;
         private boolean mHasUserGesture;
         private String mContentDisposition;
         private int mPercentCompleted = -1;
         private long mTimeRemainingInMillis;
         private boolean mIsResumable = true;
         private boolean mIsPaused;
         private boolean mIsOffTheRecord;
         private boolean mIsOfflinePage;
         private int mState = DownloadState.IN_PROGRESS;
         private long mLastAccessTime;
+        private boolean mIsVisible;
 
         public Builder setUrl(String url) {
             mUrl = url;
             return this;
         }
 
         public Builder setUserAgent(String userAgent) {
             mUserAgent = userAgent;
             return this;
         }
@@ skipping 92 matching lines @@
         public Builder setState(int downloadState) {
             mState = downloadState;
             return this;
         }
 
         public Builder setLastAccessTime(long lastAccessTime) {
             mLastAccessTime = lastAccessTime;
             return this;
         }
 
+        public Builder setIsVisible(boolean isVisible) {
+            mIsVisible = isVisible;
+            return this;
+        }
+
         public DownloadInfo build() {
             return new DownloadInfo(this);
         }
 
         /**
          * Create a builder from the DownloadInfo object.
          * @param downloadInfo DownloadInfo object from which builder fields are populated.
          * @return A builder initialized with fields from downloadInfo object.
          */
         public static Builder fromDownloadInfo(final DownloadInfo downloadInfo) {
@@ skipping 12 matching lines @@
                     .setHasUserGesture(downloadInfo.hasUserGesture())
                     .setContentDisposition(downloadInfo.getContentDisposition())
                     .setIsGETRequest(downloadInfo.isGETRequest())
                     .setPercentCompleted(downloadInfo.getPercentCompleted())
                     .setTimeRemainingInMillis(downloadInfo.getTimeRemainingInMillis())
                     .setIsResumable(downloadInfo.isResumable())
                     .setIsPaused(downloadInfo.isPaused())
                     .setIsOffTheRecord(downloadInfo.isOffTheRecord())
                     .setIsOfflinePage(downloadInfo.isOfflinePage())
                     .setState(downloadInfo.state())
-                    .setLastAccessTime(downloadInfo.getLastAccessTime());
+                    .setLastAccessTime(downloadInfo.getLastAccessTime())
+                    .setIsVisible(downloadInfo.isVisible());
             return builder;
         }
     }
 
     @CalledByNative
     private static DownloadInfo createDownloadInfo(String downloadGuid, String fileName,
             String filePath, String url, String mimeType, long bytesReceived, boolean isIncognito,
             int state, int percentCompleted, boolean isPaused, boolean hasUserGesture,
             boolean isResumable, String originalUrl, String referrerUrl, long timeRemainingInMs,
-            long lastAccessTime) {
+            long lastAccessTime, boolean isVisible) {
         String remappedMimeType = ChromeDownloadDelegate.remapGenericMimeType(
                 mimeType, url, fileName);
         return new DownloadInfo.Builder()
                 .setBytesReceived(bytesReceived)
                 .setDescription(fileName)
                 .setDownloadGuid(downloadGuid)
                 .setFileName(fileName)
                 .setFilePath(filePath)
                 .setHasUserGesture(hasUserGesture)
                 .setIsOffTheRecord(isIncognito)
                 .setIsPaused(isPaused)
                 .setIsResumable(isResumable)
                 .setMimeType(remappedMimeType)
                 .setOriginalUrl(originalUrl)
                 .setPercentCompleted(percentCompleted)
                 .setReferrer(referrerUrl)
                 .setState(state)
                 .setTimeRemainingInMillis(timeRemainingInMs)
                 .setLastAccessTime(lastAccessTime)
+                .setIsVisible(isVisible)
                 .setUrl(url)
                 .build();
     }
 }