Downloads: Added transient flag to download item and download database

chrome/browser/android/download/download_manager_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/download/download_manager_service.h"
 
 #include "base/android/jni_string.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 23 matching lines @@
 namespace {
 
 // The remaining time for a download item if it cannot be calculated.
 long kUnknownRemainingTime = -1;
 
 // Finch flag for controlling auto resumption limit.
 int kDefaultAutoResumptionLimit = 5;
 const char kAutoResumptionLimitVariation[] = "AutoResumptionLimit";
 
 bool ShouldShowDownloadItem(content::DownloadItem* item) {
-  return !item->IsTemporary();
+  return !item->IsTemporary() && item->IsVisible();
 }
 
 void UpdateNotifier(DownloadManagerService* service,
                     content::DownloadManager* manager,
                     std::unique_ptr<AllDownloadItemNotifier>& notifier) {
   if (manager) {
     if (!notifier || notifier->GetManager() != manager)
       notifier.reset(new AllDownloadItemNotifier(manager, service));
   } else {
     notifier.reset(nullptr);
   }
 }
 
 ScopedJavaLocalRef<jobject> CreateJavaDownloadItem(
     JNIEnv* env, content::DownloadItem* item) {
+  DCHECK(item->IsVisible());
   return Java_DownloadItem_createDownloadItem(
       env, DownloadManagerService::CreateJavaDownloadInfo(env, item),
       item->GetStartTime().ToJavaTime(), item->GetFileExternallyRemoved());
 }
 
 }  // namespace
 
 // static
 bool DownloadManagerService::RegisterDownloadManagerService(JNIEnv* env) {
   return RegisterNativesImpl(env);
@@ skipping 227 matching lines @@
 
   // Respond to any requests to get all downloads.
   if (pending_get_downloads_actions_ & REGULAR)
     GetAllDownloadsInternal(false);
   if (pending_get_downloads_actions_ & OFF_THE_RECORD)
     GetAllDownloadsInternal(true);
 }
 
 void DownloadManagerService::OnDownloadCreated(
     content::DownloadManager* manager, content::DownloadItem* item) {
+  if (!item->IsVisible())
+    return;
 
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_item = CreateJavaDownloadItem(env, item);
   Java_DownloadManagerService_onDownloadItemCreated(
       env, java_ref_.obj(), j_item);
 }
 
 void DownloadManagerService::OnDownloadUpdated(
     content::DownloadManager* manager, content::DownloadItem* item) {
   if (java_ref_.is_null())
     return;
 
-  if (item->IsTemporary())
+  if (item->IsTemporary() || !item->IsVisible())
     return;
 
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_item = CreateJavaDownloadItem(env, item);
   Java_DownloadManagerService_onDownloadItemUpdated(
       env, java_ref_.obj(), j_item);
 }
 
 void DownloadManagerService::OnDownloadRemoved(
     content::DownloadManager* manager, content::DownloadItem* item) {
-  if (java_ref_.is_null())
+  if (java_ref_.is_null() || !item->IsVisible())
     return;
 
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_DownloadManagerService_onDownloadItemRemoved(
       env,
       java_ref_.obj(),
       ConvertUTF8ToJavaString(env, item->GetGuid()),
       item->GetBrowserContext()->IsOffTheRecord());
 }
 
@@ skipping 136 matching lines @@
       chrome::android::kDownloadAutoResumptionThrottling,
       kAutoResumptionLimitVariation);
   int auto_resumption_limit;
   if (!variation.empty() &&
       base::StringToInt(variation, &auto_resumption_limit)) {
     return auto_resumption_limit;
   }
 
   return kDefaultAutoResumptionLimit;
 }