Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 27206002: Unify several checking methods between parser and pre-parser. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger
Modified:
7 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Unify several checking methods between parser and pre-parser. R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -192 lines) Patch
M src/parser.h View 6 chunks +9 lines, -16 lines 0 comments Download
M src/parser.cc View 6 chunks +12 lines, -21 lines 0 comments Download
M src/preparser.h View 11 chunks +90 lines, -119 lines 0 comments Download
M src/preparser.cc View 12 chunks +46 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 2 months ago (2013-10-14 16:54:32 UTC) #1
ulan
LGTM
7 years, 2 months ago (2013-10-15 07:59:41 UTC) #2
Michael Starzinger
7 years, 2 months ago (2013-10-15 08:33:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17207 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698