Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index d73063fa545314227b75691fbe8b7ba98250a51a..329a39f1c9581c2f1db41206430ce4bd50b8a298 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -291,6 +291,15 @@ int comparePositions(const VisiblePosition& a, const VisiblePosition& b) {
   return comparePositions(a.deepEquivalent(), b.deepEquivalent());
 }
 
+// TODO(editing-dev): We should implement real version which refers
+// "user-select" CSS property.
+// TODO(editing-dev): We should make |SelectionAdjuster| to use this funciton
+// instead of |isSelectionBondary()|.
+bool isUserSelectContain(const Node& node) {

[yoichio, 2017/03/02 07:31:06]

user-select:contain intends to let user selection not go
 "out" of a element.

If you want to let selection skip over some element,
 could you rename more better one?
Such like isUserSelectShouldSkipOver ?

[yosin_UTC9, 2017/03/02 07:47:17]

No this function is named to detect specified node has "user-select:content"
rather than abstract of predicate for skipping node of |PositionIterator|.

It is too early to make abstraction of iteration for selection since we've not
yet have concrete idea yet.

BTW, for PositionIterator, we also want to skip contents for elements having
"user-select:none" and "user-select:all".
Handling of them should be in another patches.

+  return isHTMLTextAreaElement(node) || isHTMLInputElement(node) ||
+         isHTMLSelectElement(node);
+}
+
 enum EditableLevel { Editable, RichlyEditable };
 static bool hasEditableLevel(const Node& node, EditableLevel editableLevel) {
   DCHECK(node.document().isActive());