headless/lib/headless_browser_context_browsertest.cc - Issue 2720543002: Fix headless_browsertests failures with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/headless_browser_context_browsertest.cc

Issue 2720543002: Fix headless_browsertests failures with PlzNavigate. (Closed)

Patch Set: review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/headless_browser_context_browsertest.cc

diff --git a/headless/lib/headless_browser_context_browsertest.cc b/headless/lib/headless_browser_context_browsertest.cc

index 49ab195c09404837850f8c4a70dfd52a2eb2fb1e..b7bfa6fcd56198205b9439cf828f155f64946e7d 100644

--- a/headless/lib/headless_browser_context_browsertest.cc

+++ b/headless/lib/headless_browser_context_browsertest.cc

@@ -196,7 +196,7 @@ IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, ContextProtocolHandler) {

another_browser_context->CreateWebContentsBuilder()

.SetInitialURL(GURL("http://not-an-actual-domain.tld/hello.html"))

.Build();

- EXPECT_TRUE(WaitForLoad(web_contents));

+ EXPECT_FALSE(WaitForLoad(web_contents));

EXPECT_TRUE(EvaluateScript(web_contents, "document.body.innerHTML")

->GetResult()

->GetValue()