Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2720543002: Fix headless_browsertests failures with PlzNavigate. (Closed)
Patch Set: review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 90b18f127d7c4edc2f45c225aa6195fb7de4ece6..51bdb0810d848a450c4a306ba3631f5ba200e637 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -382,6 +382,17 @@ void RenderFrameDevToolsAgentHost::OnBeforeNavigation(
}
// static
+void RenderFrameDevToolsAgentHost::OnFailedNavigation(
+ RenderFrameHost* host,
+ const CommonNavigationParams& common_params,
+ const BeginNavigationParams& begin_params,
+ net::Error error_code) {
+ RenderFrameDevToolsAgentHost* agent_host = FindAgentHost(host);
+ if (agent_host)
+ agent_host->OnFailedNavigation(common_params, begin_params, error_code);
+}
+
+// static
std::unique_ptr<NavigationThrottle>
RenderFrameDevToolsAgentHost::CreateThrottleForNavigation(
NavigationHandle* navigation_handle) {
@@ -720,6 +731,22 @@ void RenderFrameDevToolsAgentHost::AboutToNavigate(
DCHECK(CheckConsistency());
}
+void RenderFrameDevToolsAgentHost::OnFailedNavigation(
+ const CommonNavigationParams& common_params,
+ const BeginNavigationParams& begin_params,
+ net::Error error_code) {
+ DCHECK(IsBrowserSideNavigationEnabled());
+ if (!session())
+ return;
+
+ protocol::NetworkHandler* handler =
+ protocol::NetworkHandler::FromSession(session());
+ if (!handler)
+ return;
+
+ handler->NavigationFailed(common_params, begin_params, error_code);
+}
+
void RenderFrameDevToolsAgentHost::RenderFrameHostChanged(
RenderFrameHost* old_host,
RenderFrameHost* new_host) {
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.h ('k') | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698